Put boundary spaces around crumb names so double-clicking doesn't flip out

Summary: Occasionally, double clicking crumbs to select them is useful.

Test Plan: {F1107226}

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15263

src/view/phui/PHUICrumbView.php

@@ -73,12 +73,16 @@ final class PHUICrumbView extends AphrontView {
         ->setIcon($this->icon);
     }
 
+    // Surround the crumb name with spaces so that double clicking it only
+    // selects the crumb itself.
+    $name = array(' ', $this->name, ' ');
+
     $name = phutil_tag(
       'span',
       array(
         'class' => 'phui-crumb-name',
       ),
-      $this->name);
+      $name);
 
     $divider = null;
     if (!$this->isLastCrumb) {