From dea4901bb67da96682be40a60f186a22e379326c Mon Sep 17 00:00:00 2001 From: vrana Date: Tue, 10 Apr 2012 17:14:53 -0700 Subject: [PATCH] Unrequire filling Owners in Owners tool Summary: Owners field is filled by Primary Owner which is required. So that it is not neccessary to require filling Owners explicitly. Test Plan: Don't fill Owners and successfully save the form //before// this change. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2201 --- .../edit/PhabricatorOwnersEditController.php | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/applications/owners/controller/edit/PhabricatorOwnersEditController.php b/src/applications/owners/controller/edit/PhabricatorOwnersEditController.php index 3f219106ed..7c1ea300f4 100644 --- a/src/applications/owners/controller/edit/PhabricatorOwnersEditController.php +++ b/src/applications/owners/controller/edit/PhabricatorOwnersEditController.php @@ -41,7 +41,6 @@ final class PhabricatorOwnersEditController $e_name = true; $e_primary = true; - $e_owners = true; $errors = array(); @@ -88,13 +87,6 @@ final class PhabricatorOwnersEditController $e_primary = null; } - if (!$owners) { - $e_owners = 'Required'; - $errors[] = 'Package must have at least one owner.'; - } else { - $e_owners = null; - } - if (!$path_refs) { $errors[] = 'Package must include at least one path.'; } @@ -214,8 +206,7 @@ final class PhabricatorOwnersEditController ->setDatasource('/typeahead/common/usersorprojects/') ->setLabel('Owners') ->setName('owners') - ->setValue($token_all_owners) - ->setError($e_owners)) + ->setValue($token_all_owners)) ->appendChild( id(new AphrontFormSelectControl()) ->setName('auditing')