revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Send mail to audit comment author too

Browse source 
Summary: Previously, you would not receive a mail message for the first comment you make on an audit, but you would for subsequent comments because everyone who's made a comment would be CCed on the email. This mirrors DifferentialTransactionEditor's getMailTo which always adds `$object->getAuthorPHID()`.

Test Plan: With self mail turned on, made the first comment on a commit and received an email for it. With self mail turned off, commented on a different commit and saw in `bin/mail list-outbound` that the message was voided.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8650
This commit is contained in:
Ben Alpert 2014-03-31 07:52:51 -07:00 committed by epriestley
parent f239d81c1c
commit deba531401
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
View file

@ -429,6 +429,8 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
$email_to = array(); $email_to = array();
$email_cc = array(); $email_cc = array();
$email_to[$comment->getActorPHID()] = true;
$author_phid = $data->getCommitDetail('authorPHID'); $author_phid = $data->getCommitDetail('authorPHID');
if ($author_phid) { if ($author_phid) {
$email_to[$author_phid] = true; $email_to[$author_phid] = true;