revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
Code Issues Releases Wiki Activity

Fix broken handle rendering in Ponder

Browse source 
Summary: Ref T5817. This just fixes the markup in emails, the overall behavior still isn't great. I don't want to spend to much time on Ponder until it ends up somewhere nearer the top of the priority queue.

Test Plan: Viewed feed stories and emails, no stray/clearly-broken HTML.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5817

Differential Revision: https://secure.phabricator.com/D10231
This commit is contained in:
epriestley 2014-08-12 12:25:58 -07:00
parent a3a72c1c7d
commit dedcfd0c91
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/ponder/phid/PonderAnswerPHIDType.php
View file

@ -29,8 +29,10 @@ final class PonderAnswerPHIDType extends PhabricatorPHIDType {
$answer = $objects[$phid];
$id = $answer->getID();
$question = $answer->getQuestion();
$question_title = $question->getFullTitle();
$handle->setName("Answer {$id}");
$handle->setName("{$question_title} (Answer {$id})");
$handle->setURI($answer->getURI());
}
}

10
src/applications/ponder/storage/PonderAnswerTransaction.php
View file

@ -54,16 +54,10 @@ final class PonderAnswerTransaction
switch ($this->getTransactionType()) {
case self::TYPE_CONTENT:
$answer = $story->getObject($object_phid);
$question = $answer->getQuestion();
$answer_handle = $this->getHandle($object_phid);
$link = $answer_handle->renderLink(
$question->getFullTitle());
return pht(
'%s updated their answer to %s',
'%s updated %s.',
$this->renderHandleLink($author_phid),
$link);
$this->renderHandleLink($object_phid));
}
return parent::getTitleForFeed($story);