From deed4ffed0f6d652de8dd6a21e84c69bb2c0a326 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Tue, 31 Jan 2012 10:30:40 -0800
Subject: [PATCH] Don't output empty summary in e-mails

Summary:
Reviews with empty summary are rendered like this:

  Reviewers: ...

  TEST PLAN

Test Plan:
Use empty summary.
Use non-empty summary.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1528
---
 .../mail/reviewrequest/DifferentialReviewRequestMail.php  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php
index 00288ad0be..4e6a124f36 100644
--- a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php
+++ b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php
@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -50,8 +50,10 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail {
 
     $body = array();
     if ($this->isFirstMailToRecipients()) {
-      $body[] = $this->formatText($revision->getSummary());
-      $body[] = null;
+      if ($revision->getSummary() != '') {
+        $body[] = $this->formatText($revision->getSummary());
+        $body[] = null;
+      }
 
       $body[] = 'TEST PLAN';
       $body[] = $this->formatText($revision->getTestPlan());