revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Remove unused property "slug" from Workboard View controller

Browse source 
Summary:
Ref T4900. The Workboard view controller currently has a lot of different responsibilities (it's ~1,500 lines long) because it has to manage the board filter/sort state.

I'd like to split it up and make it easier to move some workboard features (like "move all tasks in column...") to other Controllers, so we can have smaller controllers implementing specific workflows.

I think the state handling isn't really all that bad, it just needs to be separated a little better than it currently is.

To start with, remove the unused "slug" property.

Test Plan: Searched for "slug", got no hits. This class is final and the property is private, so this is certainly unused.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T4900

Differential Revision: https://secure.phabricator.com/D20626
This commit is contained in:
epriestley 2019-06-29 12:54:10 -07:00
parent d22f6d219b
commit df29b82ad6
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View file

@ -6,7 +6,6 @@ final class PhabricatorProjectBoardViewController
const BATCH_EDIT_ALL = 'all'; const BATCH_EDIT_ALL = 'all';
private $id; private $id;
private $slug;
private $queryKey; private $queryKey;
private $sortKey; private $sortKey;
private $showHidden; private $showHidden;