From df49a6c721f96d6ab8ad6a6538b101d347fad0d1 Mon Sep 17 00:00:00 2001
From: epriestley <epriestley@phabricator.com>
Date: Sun, 6 Feb 2011 14:00:32 -0800
Subject: [PATCH] differential.updaterevision

Summary:

Test Plan: meta

Reviewers:

CC:

Differential Revision: 24
---
 src/__phutil_library_map__.php                |  2 +
 ...API_differential_updaterevision_Method.php | 70 +++++++++++++++++++
 .../differential/updaterevision/__init__.php  | 19 +++++
 3 files changed, 91 insertions(+)
 create mode 100644 src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
 create mode 100644 src/applications/conduit/method/differential/updaterevision/__init__.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 4179843da5..712d972c0f 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -68,6 +68,7 @@ phutil_register_library_map(array(
     'ConduitAPI_differential_createrevision_Method' => 'applications/conduit/method/differential/createrevision',
     'ConduitAPI_differential_parsecommitmessage_Method' => 'applications/conduit/method/differential/parsecommitmessage',
     'ConduitAPI_differential_setdiffproperty_Method' => 'applications/conduit/method/differential/setdiffproperty',
+    'ConduitAPI_differential_updaterevision_Method' => 'applications/conduit/method/differential/updaterevision',
     'ConduitAPI_file_upload_Method' => 'applications/conduit/method/file/upload',
     'ConduitAPI_user_find_Method' => 'applications/conduit/method/user/find',
     'ConduitException' => 'applications/conduit/protocol/exception',
@@ -275,6 +276,7 @@ phutil_register_library_map(array(
     'ConduitAPI_differential_createrevision_Method' => 'ConduitAPIMethod',
     'ConduitAPI_differential_parsecommitmessage_Method' => 'ConduitAPIMethod',
     'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPIMethod',
+    'ConduitAPI_differential_updaterevision_Method' => 'ConduitAPIMethod',
     'ConduitAPI_file_upload_Method' => 'ConduitAPIMethod',
     'ConduitAPI_user_find_Method' => 'ConduitAPIMethod',
     'DarkConsoleController' => 'PhabricatorController',
diff --git a/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php b/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
new file mode 100644
index 0000000000..0eeae59a66
--- /dev/null
+++ b/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
@@ -0,0 +1,70 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class ConduitAPI_differential_updaterevision_Method extends ConduitAPIMethod {
+
+  public function getMethodDescription() {
+    return "Update a Differential revision.";
+  }
+
+  public function defineParamTypes() {
+    return array(
+      'id'        => 'required revisionid',
+      'diffid'    => 'required diffid',
+      'fields'    => 'required dict',
+      'message'   => 'required string',
+    );
+  }
+
+  public function defineReturnType() {
+    return 'nonempty dict';
+  }
+
+  public function defineErrorTypes() {
+    return array(
+      'ERR_BAD_DIFF' => 'Bad diff ID.',
+      'ERR_BAD_REVISION' => 'Bad revision ID.',
+    );
+  }
+
+  protected function execute(ConduitAPIRequest $request) {
+    $diff = id(new DifferentialDiff())->load($request->getValue('diffid'));
+    if (!$diff) {
+      throw new ConduitException('ERR_BAD_DIFF');
+    }
+
+    $revision = id(new DifferentialRevision())->load($request->getValue('id'));
+
+    // TODO: verify owned, non-committed, etc.
+
+    $editor = new DifferentialRevisionEditor(
+      $revision,
+      $revision->getAuthorPHID());
+    $fields = $request->getValue('fields');
+    $editor->copyFieldsFromConduit($fields);
+
+    $editor->addDiff($diff, $request->getValue('message'));
+    $editor->save();
+
+    return array(
+      'revisionid'  => $revision->getID(),
+      'uri'         => PhabricatorEnv::getURI('/D'.$revision->getID()),
+    );
+  }
+
+}
diff --git a/src/applications/conduit/method/differential/updaterevision/__init__.php b/src/applications/conduit/method/differential/updaterevision/__init__.php
new file mode 100644
index 0000000000..7ed1c36973
--- /dev/null
+++ b/src/applications/conduit/method/differential/updaterevision/__init__.php
@@ -0,0 +1,19 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/conduit/method/base');
+phutil_require_module('phabricator', 'applications/conduit/protocol/exception');
+phutil_require_module('phabricator', 'applications/differential/editor/revision');
+phutil_require_module('phabricator', 'applications/differential/storage/diff');
+phutil_require_module('phabricator', 'applications/differential/storage/revision');
+phutil_require_module('phabricator', 'infrastructure/env');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('ConduitAPI_differential_updaterevision_Method.php');