revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Allow "Move Tasks to Column..." to prompt for MFA

Browse source 
Summary:
Ref T13074. Currently, if you "Move Tasks to Column..." on a board and some of the tasks require MFA to edit, the workflow fatals out.

After this change, it works properly. You still have to answer a separate MFA prompt for //each// task, which is a little ridiculous, but at least doable. A reasonable future refinement would be to batch these MFA prompts, but this is currently the only use case for that.

Test Plan: Set a task to a "Require MFA" status, bulk-moved it with other tasks on a workboard. Was prompted, answered MFA prompt, got a move.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13074

Differential Revision: https://secure.phabricator.com/D20282
This commit is contained in:
epriestley 2019-03-12 14:14:52 -07:00
parent 04f9e72cbd
commit df53d72e79
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View file

@ -328,7 +328,7 @@ final class PhabricatorProjectBoardViewController
$columns = null; $columns = null;
$errors = array(); $errors = array();
if ($request->isFormPost()) { if ($request->isFormOrHiSecPost()) {
$move_project_phid = head($request->getArr('moveProjectPHID')); $move_project_phid = head($request->getArr('moveProjectPHID'));
if (!$move_project_phid) { if (!$move_project_phid) {
$move_project_phid = $request->getStr('moveProjectPHID'); $move_project_phid = $request->getStr('moveProjectPHID');
@ -425,7 +425,8 @@ final class PhabricatorProjectBoardViewController
->setActor($viewer) ->setActor($viewer)
->setContinueOnMissingFields(true) ->setContinueOnMissingFields(true)
->setContinueOnNoEffect(true) ->setContinueOnNoEffect(true)
->setContentSourceFromRequest($request); ->setContentSourceFromRequest($request)
->setCancelURI($cancel_uri);
$editor->applyTransactions($move_task, $xactions); $editor->applyTransactions($move_task, $xactions);
} }