mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 14:00:56 +01:00
Conduit - Add option for createcomment to attach draft inline comments
Summary: Conduit has a query to make a draft inline comment, but createcomment doesn't have the ability to attach them. Added optional parameter to attach any existing draft comments. Default value is false, so existing api users won't be effected by the change. Test Plan: Tested no draft comments and multiple draft comments, attach_inlines =true, false, and empty. Reviewers: vrana Reviewed By: vrana CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D7019
This commit is contained in:
parent
209edcd75a
commit
df8474d778
1 changed files with 6 additions and 4 deletions
|
@ -12,10 +12,11 @@ final class ConduitAPI_differential_createcomment_Method
|
|||
|
||||
public function defineParamTypes() {
|
||||
return array(
|
||||
'revision_id' => 'required revisionid',
|
||||
'message' => 'optional string',
|
||||
'action' => 'optional string',
|
||||
'silent' => 'optional bool',
|
||||
'revision_id' => 'required revisionid',
|
||||
'message' => 'optional string',
|
||||
'action' => 'optional string',
|
||||
'silent' => 'optional bool',
|
||||
'attach_inlines' => 'optional bool',
|
||||
);
|
||||
}
|
||||
|
||||
|
@ -52,6 +53,7 @@ final class ConduitAPI_differential_createcomment_Method
|
|||
$editor->setContentSource($content_source);
|
||||
$editor->setMessage($request->getValue('message'));
|
||||
$editor->setNoEmail($request->getValue('silent'));
|
||||
$editor->setAttachInlineComments($request->getValue('attach_inlines'));
|
||||
$editor->save();
|
||||
|
||||
return array(
|
||||
|
|
Loading…
Reference in a new issue