revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Conduit - Add option for createcomment to attach draft inline comments

Browse source 
Summary:
Conduit has a query to make a draft inline comment, but createcomment doesn't have the ability to attach them.
Added optional parameter to attach any existing draft comments. Default value is false, so existing api users won't be effected by the change.

Test Plan: Tested no draft comments and multiple draft comments, attach_inlines =true, false, and empty.

Reviewers: vrana

Reviewed By: vrana

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D7019
This commit is contained in:
Joel Beales 2013-09-17 17:11:08 -07:00
parent 209edcd75a
commit df8474d778
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php
View file

@ -12,10 +12,11 @@ final class ConduitAPI_differential_createcomment_Method
public function defineParamTypes() { public function defineParamTypes() {
return array( return array(
'revision_id' => 'required revisionid', 'revision_id' => 'required revisionid',
'message' => 'optional string', 'message' => 'optional string',
'action' => 'optional string', 'action' => 'optional string',
'silent' => 'optional bool', 'silent' => 'optional bool',
'attach_inlines' => 'optional bool',
); );
} }
@ -52,6 +53,7 @@ final class ConduitAPI_differential_createcomment_Method
$editor->setContentSource($content_source); $editor->setContentSource($content_source);
$editor->setMessage($request->getValue('message')); $editor->setMessage($request->getValue('message'));
$editor->setNoEmail($request->getValue('silent')); $editor->setNoEmail($request->getValue('silent'));
$editor->setAttachInlineComments($request->getValue('attach_inlines'));
$editor->save(); $editor->save();
return array( return array(