From df9bd86890670f9d13054e5d83b7d2afec5d444e Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 31 May 2015 07:52:20 -0700
Subject: [PATCH] [Redesign] Fix Conpherence crumb border

Summary: Ref T8099, Adds a border to ConpherenceView, but not other Views. Removed some old styles.

Test Plan: Visit Conpherence Room, Thread, and Search.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13062
---
 resources/celerity/map.php                                  | 6 +++---
 .../conpherence/controller/ConpherenceController.php        | 1 -
 .../conpherence/controller/ConpherenceViewController.php    | 6 ++++++
 webroot/rsrc/css/phui/phui-crumbs-view.css                  | 1 -
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 051b66dc23..f4b60b4f0d 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'f85a5ce0',
+    'core.pkg.css' => '72f566bb',
     'core.pkg.js' => 'fbf1d615',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '30602b8c',
@@ -128,7 +128,7 @@ return array(
     'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
     'rsrc/css/phui/phui-box.css' => 'a5bb366d',
     'rsrc/css/phui/phui-button.css' => 'b995182d',
-    'rsrc/css/phui/phui-crumbs-view.css' => '3840dc4c',
+    'rsrc/css/phui/phui-crumbs-view.css' => 'ce840ec2',
     'rsrc/css/phui/phui-document.css' => '8be7a5e3',
     'rsrc/css/phui/phui-feed-story.css' => 'e5682f4c',
     'rsrc/css/phui/phui-fontkit.css' => 'b664ac96',
@@ -762,7 +762,7 @@ return array(
     'phui-calendar-day-css' => 'd1cf6f93',
     'phui-calendar-list-css' => 'c1c7f338',
     'phui-calendar-month-css' => '476be7e0',
-    'phui-crumbs-view-css' => '3840dc4c',
+    'phui-crumbs-view-css' => 'ce840ec2',
     'phui-document-view-css' => '8be7a5e3',
     'phui-feed-story-css' => 'e5682f4c',
     'phui-font-icon-base-css' => '3dad2ae3',
diff --git a/src/applications/conpherence/controller/ConpherenceController.php b/src/applications/conpherence/controller/ConpherenceController.php
index e78b5597dc..11f92454fb 100644
--- a/src/applications/conpherence/controller/ConpherenceController.php
+++ b/src/applications/conpherence/controller/ConpherenceController.php
@@ -44,7 +44,6 @@ abstract class ConpherenceController extends PhabricatorController {
 
   protected function buildConpherenceApplicationCrumbs($is_rooms = false) {
     $crumbs = parent::buildApplicationCrumbs();
-    $crumbs->setBorder(true);
 
     if ($is_rooms) {
       $crumbs
diff --git a/src/applications/conpherence/controller/ConpherenceViewController.php b/src/applications/conpherence/controller/ConpherenceViewController.php
index 6293c1bbdd..f3f1ada7e8 100644
--- a/src/applications/conpherence/controller/ConpherenceViewController.php
+++ b/src/applications/conpherence/controller/ConpherenceViewController.php
@@ -9,6 +9,12 @@ final class ConpherenceViewController extends
     return true;
   }
 
+  public function buildApplicationCrumbs() {
+    $crumbs = $this->buildConpherenceApplicationCrumbs();
+    $crumbs->setBorder(true);
+    return $crumbs;
+  }
+
   public function handleRequest(AphrontRequest $request) {
     $user = $request->getUser();
 
diff --git a/webroot/rsrc/css/phui/phui-crumbs-view.css b/webroot/rsrc/css/phui/phui-crumbs-view.css
index 6c62ee8e94..05bb281c29 100644
--- a/webroot/rsrc/css/phui/phui-crumbs-view.css
+++ b/webroot/rsrc/css/phui/phui-crumbs-view.css
@@ -18,7 +18,6 @@
   color: {$darkbluetext};
   font-weight: bold;
   text-decoration: none;
-  text-shadow: 0 1px 1px rgba(255, 255, 255, 0.9);
 }
 
 .device-phone .phui-crumbs-view {