(stable) Promote 2018 Week 38

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

@@ -23,6 +23,7 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
   private $fullWidth;
   private $infoView;
   private $editEngineLock;
+  private $noBorder;
 
   private $currentVersion;
   private $versionedDraft;
@@ -243,7 +244,6 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
 
     $comment_box = id(new PHUIObjectBoxView())
       ->setFlush(true)
-      ->setNoBorder(true)
       ->addClass('phui-comment-form-view')
       ->addSigil('phui-comment-form')
       ->appendChild(

src/view/phui/PHUIObjectBoxView.php

@@ -25,7 +25,6 @@ final class PHUIObjectBoxView extends AphrontTagView {
   private $showHideHref;
   private $showHideContent;
   private $showHideOpen;
-  private $noBorder;
 
   private $propertyLists = array();
 
@@ -148,11 +147,6 @@ final class PHUIObjectBoxView extends AphrontTagView {
     return $this;
   }
 
-  public function setNoBorder($no_border) {
-    $this->noBorder = $no_border;
-    return $this;
-  }
-
   public function setValidationException(
     PhabricatorApplicationTransactionValidationException $ex = null) {
     $this->validationException = $ex;
@@ -162,9 +156,7 @@ final class PHUIObjectBoxView extends AphrontTagView {
   protected function getTagAttributes() {
     $classes = array();
     $classes[] = 'phui-box';
-    if (!$this->noBorder) {
+    $classes[] = 'phui-box-border';
-      $classes[] = 'phui-box-border';
-    }
     $classes[] = 'phui-object-box';
     $classes[] = 'mlt mll mlr';
 

src/view/phui/PHUITimelineEventView.php

@@ -402,7 +402,7 @@ final class PHUITimelineEventView extends AphrontView {
     $wedge = phutil_tag(
       'div',
       array(
-        'class' => 'phui-timeline-wedge phui-timeline-border',
+        'class' => 'phui-timeline-wedge',
         'style' => (nonempty($image_uri)) ? '' : 'display: none;',
       ),
       '');
@@ -461,7 +461,7 @@ final class PHUITimelineEventView extends AphrontView {
     $content = phutil_tag(
       'div',
       array(
-        'class' => 'phui-timeline-group phui-timeline-border',
+        'class' => 'phui-timeline-group',
       ),
       $content);