From dffbbaf0a65b2a51281ace78c356328edfdc7d86 Mon Sep 17 00:00:00 2001 From: Brayden Winterton Date: Wed, 9 Apr 2014 07:47:31 -0700 Subject: [PATCH] Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks Summary: Arcanist is currently displaying all tasks as closed when invoking `arc tasks`. This is because arcanist is setting the display to closed if there is anything in the `status` property. Adding an isClosed property will allow arcanist to properly display open/closed status on tasks by checking against the isClosed property. The isClosed property will be set according to the closed property that is set on each status in maniphest. Test Plan: Invoke the conduit maniphest.info method on any task and insure that: # The isClosed property is included in the properties # that it is set properly according to the statuses set for maniphest. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: chad, epriestley, Korvin Maniphest Tasks: T4744 Differential Revision: https://secure.phabricator.com/D8731 --- .../maniphest/conduit/ConduitAPI_maniphest_Method.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php index 977d108fbd..f403ccfa28 100644 --- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php +++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php @@ -260,6 +260,9 @@ abstract class ConduitAPI_maniphest_Method extends ConduitAPIMethod { 'ownerPHID' => $task->getOwnerPHID(), 'ccPHIDs' => $task->getCCPHIDs(), 'status' => $task->getStatus(), + 'statusName' => ManiphestTaskStatus::getTaskStatusName( + $task->getStatus()), + 'isClosed' => $task->isClosed(), 'priority' => ManiphestTaskPriority::getTaskPriorityName( $task->getPriority()), 'title' => $task->getTitle(),