From e068b04b5c95639d191c5361c77963444184bba3 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 12 Mar 2014 17:24:58 -0700 Subject: [PATCH] Silence a warning about unknown fields in 'getcommitmessage' Summary: Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow. Test Plan: Not entirely sure how to hit this, but it won't throw anymore. Reviewers: btrahan, dctrwatson, zeeg Reviewed By: zeeg Subscribers: zeeg, aran, epriestley Differential Revision: https://secure.phabricator.com/D8514 --- .../ConduitAPI_differential_getcommitmessage_Method.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php index 287c620732..7b0b7a9511 100644 --- a/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php +++ b/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php @@ -65,11 +65,9 @@ final class ConduitAPI_differential_getcommitmessage_Method foreach ($fields as $field => $value) { $custom_field = idx($field_map, $field); if (!$custom_field) { - throw new Exception( - pht( - 'Commit message includes field "%s", but this field does not '. - 'correspond to a known field.', - $field)); + // Just ignore this, these workflows don't make strong distictions + // about field editability on the client side. + continue; } if ($is_create || $custom_field->shouldOverwriteWhenCommitMessageIsEdited()) {