From e142c7e26cdaac6de220e9b86f4a32de3d837198 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Fri, 20 Jan 2012 13:27:32 -0800
Subject: [PATCH] Improve <title> on Diffusion pages

Test Plan:
Visit /rX123.
Visit /diffusion/X/.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D1463
---
 .../controller/commit/DiffusionCommitController.php          | 5 ++---
 .../controller/repository/DiffusionRepositoryController.php  | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/applications/diffusion/controller/commit/DiffusionCommitController.php b/src/applications/diffusion/controller/commit/DiffusionCommitController.php
index 5a4829612e..cdb6abe232 100644
--- a/src/applications/diffusion/controller/commit/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/commit/DiffusionCommitController.php
@@ -192,8 +192,7 @@ class DiffusionCommitController extends DiffusionController {
         $branch = $drequest->getBranchURIComponent(
           $drequest->getBranch());
         $filename = $changeset->getFilename();
-        $commit = $drequest->getCommit();
-        $reference = "{$branch}{$filename};{$commit}";
+        $reference = "{$branch}{$filename};".$drequest->getCommit();
         $references[$key] = $reference;
       }
 
@@ -216,7 +215,7 @@ class DiffusionCommitController extends DiffusionController {
     return $this->buildStandardPageResponse(
       $content,
       array(
-        'title' => 'Diffusion',
+        'title' => 'r'.$callsign.$commit->getCommitIdentifier(),
       ));
   }
 
diff --git a/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php b/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
index f351d153d8..ea05160d1e 100644
--- a/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -106,7 +106,7 @@ class DiffusionRepositoryController extends DiffusionController {
     return $this->buildStandardPageResponse(
       $content,
       array(
-        'title' => 'Diffusion',
+        'title' => $drequest->getRepository()->getName(),
       ));
   }