From e14ba56394794ce9bfd42540f0250268fcf6bd2f Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 22 Oct 2013 08:48:12 -0700 Subject: [PATCH] Add top border back to section-headers Summary: This adds back the top border on section headers and cleans up the tab CSS just a hair. Test Plan: tested files, tasks, and custom field profile. Reviewers: epriestley, btrahan CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7378 --- src/__celerity_resource_map__.php | 94 +++++++++---------- webroot/rsrc/css/phui/phui-list.css | 12 ++- .../rsrc/css/phui/phui-property-list-view.css | 5 +- 3 files changed, 57 insertions(+), 54 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 757dd23513..99d5f93cb8 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -3885,7 +3885,7 @@ celerity_register_resource_map(array( ), 'phui-list-view-css' => array( - 'uri' => '/res/c748be1f/rsrc/css/phui/phui-list.css', + 'uri' => '/res/fbf42225/rsrc/css/phui/phui-list.css', 'type' => 'css', 'requires' => array( @@ -3921,7 +3921,7 @@ celerity_register_resource_map(array( ), 'phui-property-list-view-css' => array( - 'uri' => '/res/81bdc80f/rsrc/css/phui/phui-property-list-view.css', + 'uri' => '/res/dc22cea9/rsrc/css/phui/phui-property-list-view.css', 'type' => 'css', 'requires' => array( @@ -4309,7 +4309,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - 'c35f1eca' => + 'e7bcbe65' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4358,7 +4358,7 @@ celerity_register_resource_map(array( 41 => 'phabricator-tag-view-css', 42 => 'phui-list-view-css', ), - 'uri' => '/res/pkg/c35f1eca/core.pkg.css', + 'uri' => '/res/pkg/e7bcbe65/core.pkg.css', 'type' => 'css', ), '2c1dba03' => @@ -4550,15 +4550,15 @@ celerity_register_resource_map(array( ), 'reverse' => array( - 'aphront-dialog-view-css' => 'c35f1eca', - 'aphront-error-view-css' => 'c35f1eca', - 'aphront-list-filter-view-css' => 'c35f1eca', - 'aphront-pager-view-css' => 'c35f1eca', - 'aphront-panel-view-css' => 'c35f1eca', - 'aphront-table-view-css' => 'c35f1eca', - 'aphront-tokenizer-control-css' => 'c35f1eca', - 'aphront-tooltip-css' => 'c35f1eca', - 'aphront-typeahead-control-css' => 'c35f1eca', + 'aphront-dialog-view-css' => 'e7bcbe65', + 'aphront-error-view-css' => 'e7bcbe65', + 'aphront-list-filter-view-css' => 'e7bcbe65', + 'aphront-pager-view-css' => 'e7bcbe65', + 'aphront-panel-view-css' => 'e7bcbe65', + 'aphront-table-view-css' => 'e7bcbe65', + 'aphront-tokenizer-control-css' => 'e7bcbe65', + 'aphront-tooltip-css' => 'e7bcbe65', + 'aphront-typeahead-control-css' => 'e7bcbe65', 'differential-changeset-view-css' => '0fe5af56', 'differential-core-view-css' => '0fe5af56', 'differential-inline-comment-editor' => '5e9e5c4e', @@ -4572,7 +4572,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => '0fe5af56', 'diffusion-commit-view-css' => '270f4eb4', 'diffusion-icons-css' => '270f4eb4', - 'global-drag-and-drop-css' => 'c35f1eca', + 'global-drag-and-drop-css' => 'e7bcbe65', 'inline-comment-summary-css' => '0fe5af56', 'javelin-aphlict' => '2c1dba03', 'javelin-behavior' => '3e3be199', @@ -4647,56 +4647,56 @@ celerity_register_resource_map(array( 'javelin-util' => '3e3be199', 'javelin-vector' => '3e3be199', 'javelin-workflow' => '3e3be199', - 'lightbox-attachment-css' => 'c35f1eca', + 'lightbox-attachment-css' => 'e7bcbe65', 'maniphest-task-summary-css' => '49898640', - 'phabricator-action-list-view-css' => 'c35f1eca', - 'phabricator-application-launch-view-css' => 'c35f1eca', + 'phabricator-action-list-view-css' => 'e7bcbe65', + 'phabricator-application-launch-view-css' => 'e7bcbe65', 'phabricator-busy' => '2c1dba03', 'phabricator-content-source-view-css' => '0fe5af56', - 'phabricator-core-css' => 'c35f1eca', - 'phabricator-crumbs-view-css' => 'c35f1eca', + 'phabricator-core-css' => 'e7bcbe65', + 'phabricator-crumbs-view-css' => 'e7bcbe65', 'phabricator-drag-and-drop-file-upload' => '5e9e5c4e', 'phabricator-dropdown-menu' => '2c1dba03', 'phabricator-file-upload' => '2c1dba03', - 'phabricator-filetree-view-css' => 'c35f1eca', - 'phabricator-flag-css' => 'c35f1eca', + 'phabricator-filetree-view-css' => 'e7bcbe65', + 'phabricator-flag-css' => 'e7bcbe65', 'phabricator-hovercard' => '2c1dba03', - 'phabricator-jump-nav' => 'c35f1eca', + 'phabricator-jump-nav' => 'e7bcbe65', 'phabricator-keyboard-shortcut' => '2c1dba03', 'phabricator-keyboard-shortcut-manager' => '2c1dba03', - 'phabricator-main-menu-view' => 'c35f1eca', + 'phabricator-main-menu-view' => 'e7bcbe65', 'phabricator-menu-item' => '2c1dba03', - 'phabricator-nav-view-css' => 'c35f1eca', + 'phabricator-nav-view-css' => 'e7bcbe65', 'phabricator-notification' => '2c1dba03', - 'phabricator-notification-css' => 'c35f1eca', - 'phabricator-notification-menu-css' => 'c35f1eca', + 'phabricator-notification-css' => 'e7bcbe65', + 'phabricator-notification-menu-css' => 'e7bcbe65', 'phabricator-object-selector-css' => '0fe5af56', 'phabricator-phtize' => '2c1dba03', 'phabricator-prefab' => '2c1dba03', 'phabricator-project-tag-css' => '49898640', - 'phabricator-remarkup-css' => 'c35f1eca', + 'phabricator-remarkup-css' => 'e7bcbe65', 'phabricator-shaped-request' => '5e9e5c4e', - 'phabricator-side-menu-view-css' => 'c35f1eca', - 'phabricator-standard-page-view' => 'c35f1eca', - 'phabricator-tag-view-css' => 'c35f1eca', + 'phabricator-side-menu-view-css' => 'e7bcbe65', + 'phabricator-standard-page-view' => 'e7bcbe65', + 'phabricator-tag-view-css' => 'e7bcbe65', 'phabricator-textareautils' => '2c1dba03', 'phabricator-tooltip' => '2c1dba03', - 'phabricator-transaction-view-css' => 'c35f1eca', - 'phabricator-zindex-css' => 'c35f1eca', - 'phui-button-css' => 'c35f1eca', - 'phui-form-css' => 'c35f1eca', - 'phui-form-view-css' => 'c35f1eca', - 'phui-header-view-css' => 'c35f1eca', - 'phui-icon-view-css' => 'c35f1eca', - 'phui-list-view-css' => 'c35f1eca', - 'phui-object-item-list-view-css' => 'c35f1eca', - 'phui-property-list-view-css' => 'c35f1eca', - 'phui-spacing-css' => 'c35f1eca', - 'sprite-apps-large-css' => 'c35f1eca', - 'sprite-gradient-css' => 'c35f1eca', - 'sprite-icons-css' => 'c35f1eca', - 'sprite-menu-css' => 'c35f1eca', - 'sprite-status-css' => 'c35f1eca', - 'syntax-highlighting-css' => 'c35f1eca', + 'phabricator-transaction-view-css' => 'e7bcbe65', + 'phabricator-zindex-css' => 'e7bcbe65', + 'phui-button-css' => 'e7bcbe65', + 'phui-form-css' => 'e7bcbe65', + 'phui-form-view-css' => 'e7bcbe65', + 'phui-header-view-css' => 'e7bcbe65', + 'phui-icon-view-css' => 'e7bcbe65', + 'phui-list-view-css' => 'e7bcbe65', + 'phui-object-item-list-view-css' => 'e7bcbe65', + 'phui-property-list-view-css' => 'e7bcbe65', + 'phui-spacing-css' => 'e7bcbe65', + 'sprite-apps-large-css' => 'e7bcbe65', + 'sprite-gradient-css' => 'e7bcbe65', + 'sprite-icons-css' => 'e7bcbe65', + 'sprite-menu-css' => 'e7bcbe65', + 'sprite-status-css' => 'e7bcbe65', + 'syntax-highlighting-css' => 'e7bcbe65', ), )); diff --git a/webroot/rsrc/css/phui/phui-list.css b/webroot/rsrc/css/phui/phui-list.css index 63ff094fc8..318e4ee5a0 100644 --- a/webroot/rsrc/css/phui/phui-list.css +++ b/webroot/rsrc/css/phui/phui-list.css @@ -87,6 +87,7 @@ list-style: none; overflow: hidden; border-bottom: 1px solid #e7e7e7; + background: {$lightgreybackground}; } .phui-list-view.phui-list-navbar > li { @@ -101,19 +102,20 @@ } .phui-list-navbar .phui-list-item-href { - color: #9ca5b5; + color: {$lightbluetext}; padding: 8px 16px; font-size: 12px; + letter-spacing: 0.5px; } .phui-list-navbar .phui-list-item-selected .phui-list-item-href { - background: #f6f7f8; - color: #555; + background: {$greybackground}; + color: {$darkbluetext}; } .phui-list-navbar .phui-list-item-href:hover { - background: #e8e9ec; - color: #555; + background: #DEE0E4; + color: {$darkgreytext}; text-decoration: none; } diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css index 31edfc1901..e97eb9a4a7 100644 --- a/webroot/rsrc/css/phui/phui-property-list-view.css +++ b/webroot/rsrc/css/phui/phui-property-list-view.css @@ -23,8 +23,6 @@ display: none; } -.phui-property-list-section + - .phui-property-list-section, .phui-property-group-noninitial { border-color: {$thinblueborder}; border-style: solid; @@ -83,6 +81,9 @@ padding: 12px 16px 0px; text-transform: uppercase; font-weight: 700; + border-color: {$thinblueborder}; + border-style: solid; + border-width: 1px 0 0; } .device .phui-property-list-section-header {