revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Fix a Calendar import issue where we looked up attendees by object instead of name

Browse source 
Summary:
Ref T11801. This issue led to the stack trace in T11801#199042.

It wasn't obvious that this was wrong because the recover-on-duplicate-key code made it work correctly.

Test Plan: Imported an event with external attendees with no warnings in the log.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11801

Differential Revision: https://secure.phabricator.com/D16804
This commit is contained in:
epriestley 2016-11-05 09:24:40 -07:00
parent bd3233d3ab
commit e1566bef63
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
View file

@ -259,7 +259,7 @@ abstract class PhabricatorCalendarImportEngine
if ($attendee_names) { if ($attendee_names) {
$external_invitees = id(new PhabricatorCalendarExternalInviteeQuery()) $external_invitees = id(new PhabricatorCalendarExternalInviteeQuery())
->setViewer($viewer) ->setViewer($viewer)
->withNames($attendee_names) ->withNames(array_keys($attendee_names))
->execute(); ->execute();
$external_invitees = mpull($external_invitees, null, 'getName'); $external_invitees = mpull($external_invitees, null, 'getName');