From e1d09fd035f597dec658e7d9621d5cfefba8d78a Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 3 Mar 2015 10:39:32 -0800 Subject: [PATCH] Show change details for "Remarkup" standard custom field edits Summary: Fixes T7436. Test Plan: {F328222} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7436 Differential Revision: https://secure.phabricator.com/D11952 --- .../PhabricatorStandardCustomFieldRemarkup.php | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php index 3c56bf75c0..d1bf5469f7 100644 --- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php +++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php @@ -50,15 +50,26 @@ final class PhabricatorStandardCustomFieldRemarkup public function getApplicationTransactionTitle( PhabricatorApplicationTransaction $xaction) { $author_phid = $xaction->getAuthorPHID(); - - // TODO: Expose fancy transactions. - return pht( '%s edited %s.', $xaction->renderHandleLink($author_phid), $this->getFieldName()); } + public function getApplicationTransactionHasChangeDetails( + PhabricatorApplicationTransaction $xaction) { + return true; + } + + public function getApplicationTransactionChangeDetails( + PhabricatorApplicationTransaction $xaction, + PhabricatorUser $viewer) { + return $xaction->renderTextCorpusChangeDetails( + $viewer, + $xaction->getOldValue(), + $xaction->getNewValue()); + } + public function shouldAppearInHerald() { return true; }