1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

Fix a bad getStatus() call which is fataling during Herald rule evaluation

Summary: Hit this while `arc diff`'ing something which is triggering 2+ rules which add reviewers, I think.

Test Plan: Dug this out of a production stack trace; will push and `arc diff` again.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17534
This commit is contained in:
epriestley 2017-03-22 09:46:45 -07:00
parent 9c998e988b
commit e1ee8ba428

View file

@ -57,7 +57,7 @@ abstract class DifferentialReviewersHeraldAction
// If we're applying a stronger status (usually, upgrading a reviewer
// into a blocking reviewer), skip this check so we apply the change.
$old_strength = DifferentialReviewerStatus::getStatusStrength(
$reviewers[$phid]->getStatus());
$reviewers[$phid]->getReviewerStatus());
if ($old_strength <= $new_strength) {
continue;
}