mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-23 07:12:41 +01:00
Fix a bad getStatus() call which is fataling during Herald rule evaluation
Summary: Hit this while `arc diff`'ing something which is triggering 2+ rules which add reviewers, I think. Test Plan: Dug this out of a production stack trace; will push and `arc diff` again. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17534
This commit is contained in:
parent
9c998e988b
commit
e1ee8ba428
1 changed files with 1 additions and 1 deletions
|
@ -57,7 +57,7 @@ abstract class DifferentialReviewersHeraldAction
|
|||
// If we're applying a stronger status (usually, upgrading a reviewer
|
||||
// into a blocking reviewer), skip this check so we apply the change.
|
||||
$old_strength = DifferentialReviewerStatus::getStatusStrength(
|
||||
$reviewers[$phid]->getStatus());
|
||||
$reviewers[$phid]->getReviewerStatus());
|
||||
if ($old_strength <= $new_strength) {
|
||||
continue;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue