From e246001bd2618c26cd0fbde5c6c03bc96936d387 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 25 Mar 2013 12:20:49 -0700 Subject: [PATCH] Tighten up CSS on object-list a bit. Summary: - Fix unintended round edges. - Reduce height 4px; - Align title and date - Fix mobile/tablet spacing Test Plan: Photoshop, UIExamples, Config, Paste, Maniphests (all mobile and desktop views) Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5445 --- src/__celerity_resource_map__.php | 78 +++++++++---------- .../phabricator-object-item-list-view.css | 12 ++- 2 files changed, 44 insertions(+), 46 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 34c8a0e3a4..be9be7d5a5 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -3003,7 +3003,7 @@ celerity_register_resource_map(array( ), 'phabricator-object-item-list-view-css' => array( - 'uri' => '/res/db1f60e6/rsrc/css/layout/phabricator-object-item-list-view.css', + 'uri' => '/res/cfa3fbd9/rsrc/css/layout/phabricator-object-item-list-view.css', 'type' => 'css', 'requires' => array( @@ -3701,7 +3701,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - 'ac1d92f5' => + '93e81012' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3743,7 +3743,7 @@ celerity_register_resource_map(array( 34 => 'phabricator-object-item-list-view-css', 35 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/ac1d92f5/core.pkg.css', + 'uri' => '/res/pkg/93e81012/core.pkg.css', 'type' => 'css', ), '95ceba95' => @@ -3934,16 +3934,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => '6b1fccc6', - 'aphront-dialog-view-css' => 'ac1d92f5', - 'aphront-error-view-css' => 'ac1d92f5', - 'aphront-form-view-css' => 'ac1d92f5', - 'aphront-list-filter-view-css' => 'ac1d92f5', - 'aphront-pager-view-css' => 'ac1d92f5', - 'aphront-panel-view-css' => 'ac1d92f5', - 'aphront-table-view-css' => 'ac1d92f5', - 'aphront-tokenizer-control-css' => 'ac1d92f5', - 'aphront-tooltip-css' => 'ac1d92f5', - 'aphront-typeahead-control-css' => 'ac1d92f5', + 'aphront-dialog-view-css' => '93e81012', + 'aphront-error-view-css' => '93e81012', + 'aphront-form-view-css' => '93e81012', + 'aphront-list-filter-view-css' => '93e81012', + 'aphront-pager-view-css' => '93e81012', + 'aphront-panel-view-css' => '93e81012', + 'aphront-table-view-css' => '93e81012', + 'aphront-tokenizer-control-css' => '93e81012', + 'aphront-tooltip-css' => '93e81012', + 'aphront-typeahead-control-css' => '93e81012', 'differential-changeset-view-css' => '8aaacd1b', 'differential-core-view-css' => '8aaacd1b', 'differential-inline-comment-editor' => '322728f3', @@ -3957,7 +3957,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => '8aaacd1b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => 'ac1d92f5', + 'global-drag-and-drop-css' => '93e81012', 'inline-comment-summary-css' => '8aaacd1b', 'javelin-aphlict' => '95ceba95', 'javelin-behavior' => 'fe22443b', @@ -4029,48 +4029,48 @@ celerity_register_resource_map(array( 'javelin-util' => 'fe22443b', 'javelin-vector' => 'fe22443b', 'javelin-workflow' => 'fe22443b', - 'lightbox-attachment-css' => 'ac1d92f5', + 'lightbox-attachment-css' => '93e81012', 'maniphest-task-summary-css' => '6b1fccc6', 'maniphest-transaction-detail-css' => '6b1fccc6', 'phabricator-busy' => '95ceba95', 'phabricator-content-source-view-css' => '8aaacd1b', - 'phabricator-core-buttons-css' => 'ac1d92f5', - 'phabricator-core-css' => 'ac1d92f5', - 'phabricator-crumbs-view-css' => 'ac1d92f5', - 'phabricator-directory-css' => 'ac1d92f5', + 'phabricator-core-buttons-css' => '93e81012', + 'phabricator-core-css' => '93e81012', + 'phabricator-crumbs-view-css' => '93e81012', + 'phabricator-directory-css' => '93e81012', 'phabricator-drag-and-drop-file-upload' => '322728f3', 'phabricator-dropdown-menu' => '95ceba95', 'phabricator-file-upload' => '95ceba95', - 'phabricator-filetree-view-css' => 'ac1d92f5', - 'phabricator-flag-css' => 'ac1d92f5', - 'phabricator-form-view-css' => 'ac1d92f5', - 'phabricator-header-view-css' => 'ac1d92f5', - 'phabricator-jump-nav' => 'ac1d92f5', + 'phabricator-filetree-view-css' => '93e81012', + 'phabricator-flag-css' => '93e81012', + 'phabricator-form-view-css' => '93e81012', + 'phabricator-header-view-css' => '93e81012', + 'phabricator-jump-nav' => '93e81012', 'phabricator-keyboard-shortcut' => '95ceba95', 'phabricator-keyboard-shortcut-manager' => '95ceba95', - 'phabricator-main-menu-view' => 'ac1d92f5', + 'phabricator-main-menu-view' => '93e81012', 'phabricator-menu-item' => '95ceba95', - 'phabricator-nav-view-css' => 'ac1d92f5', + 'phabricator-nav-view-css' => '93e81012', 'phabricator-notification' => '95ceba95', - 'phabricator-notification-css' => 'ac1d92f5', - 'phabricator-notification-menu-css' => 'ac1d92f5', - 'phabricator-object-item-list-view-css' => 'ac1d92f5', + 'phabricator-notification-css' => '93e81012', + 'phabricator-notification-menu-css' => '93e81012', + 'phabricator-object-item-list-view-css' => '93e81012', 'phabricator-object-selector-css' => '8aaacd1b', 'phabricator-paste-file-upload' => '95ceba95', 'phabricator-prefab' => '95ceba95', 'phabricator-project-tag-css' => '6b1fccc6', - 'phabricator-remarkup-css' => 'ac1d92f5', + 'phabricator-remarkup-css' => '93e81012', 'phabricator-shaped-request' => '322728f3', - 'phabricator-side-menu-view-css' => 'ac1d92f5', - 'phabricator-standard-page-view' => 'ac1d92f5', + 'phabricator-side-menu-view-css' => '93e81012', + 'phabricator-standard-page-view' => '93e81012', 'phabricator-textareautils' => '95ceba95', 'phabricator-tooltip' => '95ceba95', - 'phabricator-transaction-view-css' => 'ac1d92f5', - 'phabricator-zindex-css' => 'ac1d92f5', - 'sprite-apps-large-css' => 'ac1d92f5', - 'sprite-gradient-css' => 'ac1d92f5', - 'sprite-icon-css' => 'ac1d92f5', - 'sprite-menu-css' => 'ac1d92f5', - 'syntax-highlighting-css' => 'ac1d92f5', + 'phabricator-transaction-view-css' => '93e81012', + 'phabricator-zindex-css' => '93e81012', + 'sprite-apps-large-css' => '93e81012', + 'sprite-gradient-css' => '93e81012', + 'sprite-icon-css' => '93e81012', + 'sprite-menu-css' => '93e81012', + 'syntax-highlighting-css' => '93e81012', ), )); diff --git a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css index 0932965d46..1390498332 100644 --- a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css +++ b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css @@ -10,7 +10,7 @@ padding: 20px; } -.device-desktop .phabricator-object-list-flush { +.phabricator-object-item-list-view.phabricator-object-list-flush { padding: 0; } @@ -31,6 +31,9 @@ border-width: 1px 1px 1px 0; overflow: hidden; position: relative; +} + +.phabricator-object-list-cards .phabricator-object-item-frame { border-bottom-right-radius: 3px; border-top-right-radius: 3px; } @@ -136,7 +139,7 @@ } .phabricator-object-item-with-handle-icons .phabricator-object-item-icons { - padding-bottom: 34px; + padding-bottom: 30px; } .phabricator-object-item-icons { @@ -360,11 +363,6 @@ padding: 6px 0; } -.phabricator-object-list-cards .phabricator-object-item-with-attrs - .phabricator-object-item-link { - padding: 4px 0; -} - .phabricator-object-list-cards .phabricator-object-item-selected { background: #bfdcff; }