revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/>.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain `feed.http-hooks` compatibility for now.

Test Plan: {F6190681}

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20114
This commit is contained in:
epriestley 2019-02-06 16:17:09 -08:00
parent 26081594e2
commit e25dc2dfe2
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/feed/worker/FeedPublisherHTTPWorker.php
View file

@ -26,6 +26,11 @@ final class FeedPublisherHTTPWorker extends FeedPushWorker {
'epoch' => $data->getEpoch(), 'epoch' => $data->getEpoch(),
); );
// NOTE: We're explicitly using "http_build_query()" here because the
// "storyData" parameter may be a nested object with arbitrary nested
// sub-objects.
$post_data = http_build_query($post_data, '', '&');
id(new HTTPSFuture($uri, $post_data)) id(new HTTPSFuture($uri, $post_data))
->setMethod('POST') ->setMethod('POST')
->setTimeout(30) ->setTimeout(30)