Update Conduit for new UI

Summary: View various conduit pages and update to new UI and add calls to newPage

Test Plan: View list, view method, make a call.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15613

src/applications/conduit/controller/PhabricatorConduitAPIController.php

@@ -511,19 +511,22 @@ final class PhabricatorConduitAPIController
         'wide',
       ));
 
-    $param_panel = new PHUIObjectBoxView();
+    $param_panel = id(new PHUIObjectBoxView())
-    $param_panel->setHeaderText(pht('Method Parameters'));
+      ->setHeaderText(pht('Method Parameters'))
-    $param_panel->setTable($param_table);
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->setTable($param_table);
 
-    $result_panel = new PHUIObjectBoxView();
+    $result_panel = id(new PHUIObjectBoxView())
-    $result_panel->setHeaderText(pht('Method Result'));
+      ->setHeaderText(pht('Method Result'))
-    $result_panel->setTable($result_table);
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->setTable($result_table);
 
     $method_uri = $this->getApplicationURI('method/'.$method.'/');
 
     $crumbs = $this->buildApplicationCrumbs()
       ->addTextCrumb($method, $method_uri)
-      ->addTextCrumb(pht('Call'));
+      ->addTextCrumb(pht('Call'))
+      ->setBorder(true);
 
     $example_panel = null;
     if ($request && $method_implementation) {
@@ -533,16 +536,26 @@ final class PhabricatorConduitAPIController
         $params);
     }
 
-    return $this->buildApplicationPage(
+    $title = pht('Method Call Result');
-      array(
+    $header = id(new PHUIHeaderView())
-        $crumbs,
+      ->setHeader($title)
+      ->setHeaderIcon('fa-exchange');
+
+    $view = id(new PHUITwoColumnView())
+      ->setHeader($header)
+      ->setFooter(array(
         $param_panel,
         $result_panel,
         $example_panel,
-      ),
-      array(
-        'title' => pht('Method Call Result'),
       ));
+
+    $title = pht('Method Call Result');
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
+
   }
 
   private function renderAPIValue($value) {

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

@@ -85,37 +85,41 @@ final class PhabricatorConduitConsoleController
 
     $header = id(new PHUIHeaderView())
       ->setUser($viewer)
-      ->setHeader($method->getAPIMethodName());
+      ->setHeader($method->getAPIMethodName())
+      ->setHeaderIcon('fa-tty');
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Call Method'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setForm($form);
 
-    $content = array();
-
     $properties = $this->buildMethodProperties($method);
 
     $info_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('API Method: %s', $method->getAPIMethodName()))
       ->setFormErrors($errors)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($properties);
 
-    $content[] = $info_box;
-    $content[] = $method->getMethodDocumentation();
-    $content[] = $form_box;
-    $content[] = $this->renderExampleBox($method, null);
-
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($method->getAPIMethodName());
+    $crumbs->setBorder(true);
 
-    return $this->buildApplicationPage(
+    $view = id(new PHUITwoColumnView())
-      array(
+      ->setHeader($header)
-        $crumbs,
+      ->setFooter(array(
-        $content,
+        $info_box,
-      ),
+        $method->getMethodDocumentation(),
-      array(
+        $form_box,
-        'title' => $method->getAPIMethodName(),
+        $this->renderExampleBox($method, null),
       ));
+
+    $title = $method->getAPIMethodName();
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
   private function buildMethodProperties(ConduitAPIMethod $method) {

src/applications/conduit/controller/PhabricatorConduitController.php

@@ -56,6 +56,7 @@ abstract class PhabricatorConduitController extends PhabricatorController {
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Examples'))
       ->setInfoView($info_view)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->addPropertyList($arc_example, pht('arc call-conduit'))
       ->addPropertyList($curl_example, pht('cURL'))
       ->addPropertyList($php_example, pht('PHP'));

src/applications/conduit/controller/PhabricatorConduitTokenController.php

@@ -55,19 +55,26 @@ final class PhabricatorConduitTokenController
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb(pht('Install Certificate'));
+    $crumbs->setBorder(true);
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Certificate Token'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setForm($form);
 
-    return $this->buildApplicationPage(
+    $title = pht('Certificate Install Token');
-      array(
+
-        $crumbs,
+    $header = id(new PHUIHeaderView())
-        $object_box,
+      ->setHeader($title);
-      ),
+
-      array(
+    $view = id(new PHUITwoColumnView())
-        'title' => pht('Certificate Install Token'),
+      ->setHeader($header)
-      ));
+      ->setFooter($object_box);
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
 }

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

@@ -151,6 +151,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Builtin and Saved Queries'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($info))
       ->appendChild($table);
   }
@@ -236,6 +237,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Custom Query Constraints'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($info))
       ->appendChild($table);
   }
@@ -342,6 +344,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Result Ordering'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($orders_info))
       ->appendChild($orders_table)
       ->appendChild($this->buildRemarkup($columns_info))
@@ -422,6 +425,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Object Fields'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($info))
       ->appendChild($table);
   }
@@ -510,6 +514,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Attachments'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($info))
       ->appendChild($table);
   }
@@ -580,6 +585,7 @@ EOTEXT
     return id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Paging and Limits'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($info));
   }
 

src/applications/transactions/editengine/PhabricatorEditEngineAPIMethod.php

@@ -94,6 +94,7 @@ abstract class PhabricatorEditEngineAPIMethod
     $boxes[] = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Transaction Types'))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($summary_info))
       ->appendChild($summary_table);
 
@@ -140,6 +141,7 @@ abstract class PhabricatorEditEngineAPIMethod
       $boxes[] = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Transaction Type: %s', $type->getEditType()))
       ->setCollapsed(true)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->appendChild($this->buildRemarkup($section))
       ->appendChild($type_table);
     }