revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-03 11:21:01 +01:00
Code Issues Releases Wiki Activity

Fix mobile menu for files in Differential Changesets

Browse source 
Summary: Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu.

Test Plan:
View on mobile, desktop, browser. Click an action, spawn new page.

{F1717953}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T7754, T11305

Differential Revision: https://secure.phabricator.com/D16265
This commit is contained in:
Chad Little 2016-07-09 13:53:57 -07:00
parent 660747d649
commit e2d195e03a
3 changed files with 18 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -10,7 +10,7 @@ return array(
'core.pkg.css' => '4e7e9bde', 'core.pkg.css' => '4e7e9bde',
'core.pkg.js' => '13c7e56a', 'core.pkg.js' => '13c7e56a',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '3e81ae60', 'differential.pkg.css' => '3fb7f532',
'differential.pkg.js' => '634399e9', 'differential.pkg.js' => '634399e9',
'diffusion.pkg.css' => '91c5d3a6', 'diffusion.pkg.css' => '91c5d3a6',
'diffusion.pkg.js' => '84c8f8fd', 'diffusion.pkg.js' => '84c8f8fd',
@ -57,7 +57,7 @@ return array(
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127', 'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a', 'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
'rsrc/css/application/differential/changeset-view.css' => '37792573', 'rsrc/css/application/differential/changeset-view.css' => '9ef7d354',
'rsrc/css/application/differential/core.css' => '5b7b8ff4', 'rsrc/css/application/differential/core.css' => '5b7b8ff4',
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e', 'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
'rsrc/css/application/differential/revision-comment.css' => '14b8565a', 'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@ -555,7 +555,7 @@ return array(
'conpherence-update-css' => 'faf6be09', 'conpherence-update-css' => 'faf6be09',
'conpherence-widget-pane-css' => '775eaaba', 'conpherence-widget-pane-css' => '775eaaba',
'd3' => 'a11a5ff2', 'd3' => 'a11a5ff2',
'differential-changeset-view-css' => '37792573', 'differential-changeset-view-css' => '9ef7d354',
'differential-core-view-css' => '5b7b8ff4', 'differential-core-view-css' => '5b7b8ff4',
'differential-inline-comment-editor' => '64a5550f', 'differential-inline-comment-editor' => '64a5550f',
'differential-revision-add-comment-css' => 'c47f8c40', 'differential-revision-add-comment-css' => 'c47f8c40',
@ -1143,9 +1143,6 @@ return array(
'javelin-dom', 'javelin-dom',
'javelin-workflow', 'javelin-workflow',
), ),
37792573 => array(
'phui-inline-comment-view-css',
),
'3ab51e2c' => array( '3ab51e2c' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-behavior-device', 'javelin-behavior-device',
@ -1678,6 +1675,9 @@ return array(
'phabricator-phtize', 'phabricator-phtize',
'changeset-view-manager', 'changeset-view-manager',
), ),
'9ef7d354' => array(
'phui-inline-comment-view-css',
),
'9f36c42d' => array( '9f36c42d' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-stratcom', 'javelin-stratcom',

20
src/applications/differential/view/DifferentialChangesetListView.php
View file

@ -342,18 +342,16 @@ final class DifferentialChangesetListView extends AphrontView {
} }
$meta['containerID'] = $detail->getID(); $meta['containerID'] = $detail->getID();
$caret = phutil_tag('span', array('class' => 'caret'), '');
return javelin_tag( return id(new PHUIButtonView())
'a', ->setTag('a')
array( ->setText(pht('View Options'))
'class' => 'button grey dropdown', ->setIcon('fa-bars')
'meta' => $meta, ->setColor(PHUIButtonView::GREY)
'href' => idx($meta, 'detailURI', '#'), ->setHref(idx($meta, 'detailURI', '#'))
'target' => '_blank', ->setMetadata($meta)
'sigil' => 'differential-view-options', ->addSigil('differential-view-options');
),
array(pht('View Options'), $caret));
} }
} }

9
webroot/rsrc/css/application/differential/changeset-view.css
View file

@ -348,12 +348,9 @@ td.cov-I {
margin-right: 12px; margin-right: 12px;
} }
.device-phone .differential-changeset-buttons { .device-phone .differential-changeset-buttons .button .phui-button-text {
float: none; visibility: hidden;
margin: 0 0 8px 4px; width: 0;
}
.differential-changeset-buttons a.button {
margin-left: 8px; margin-left: 8px;
} }