1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00

Touch up Audit/Commit List UI

Summary: Fixes a few issues. The author of the commit is more prominent / not cut off. Auditors is in a more consistent location. More space is available for reasons. Commits by themselves look much less janky. Only downside is actual Audits are now 3 lines vs. 2, but the extra space is used well.

Test Plan:
Test list of audits and commits.

{F309237}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11817
This commit is contained in:
Chad Little 2015-02-19 07:03:18 -08:00
parent b1ed68b8fe
commit e2fcc3c187

View file

@ -152,10 +152,10 @@ final class PhabricatorAuditListView extends AphrontView {
->addAttribute($status_text) ->addAttribute($status_text)
->addAttribute($reasons) ->addAttribute($reasons)
->addIcon('none', $committed) ->addIcon('none', $committed)
->addByline($author_name); ->setSubHead(pht('Author: %s', $author_name));
if (!empty($auditors)) { if (!empty($auditors)) {
$item->addAttribute(pht('Auditors: %s', $auditors)); $item->addByLine(pht('Auditors: %s', $auditors));
} }
$list->addItem($item); $list->addItem($item);