From e313b1d64a5bd6bd6988d2da4c0c0919b9a21132 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 9 May 2011 17:00:20 -0700 Subject: [PATCH] Add square brackets around new revision review requests Summary: These didn't get covered when we added square brackets to the rest of the emails (so gmail can thread them properly). Test Plan: Created a local diff, got an email with brackets. Reviewed By: tuomaspelkonen Reviewers: rm, tuomaspelkonen, jungejason, aran CC: aran, epriestley, tuomaspelkonen Differential Revision: 256 --- .../differential/mail/newdiff/DifferentialNewDiffMail.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php b/src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php index 82fcbe9b1a..1507011844 100644 --- a/src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php +++ b/src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php @@ -29,7 +29,10 @@ class DifferentialNewDiffMail extends DifferentialReviewRequestMail { $verb = 'Updated'; } - return "{$verb} ({$lines}): ".$revision->getTitle(); + $revision_id = $revision->getID(); + $revision_title = $revision->getTitle(); + + return "[{$verb}, {$lines}] D{$revision_id}: {$revision_title}"; } protected function buildSubject() {