revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Correctly focus elements in Workflow dialogs

Browse source 
Summary:
JX.Workflow does a JX.DOM.find() for the sigil __default__, but fails because we
render with phutil_render_tag() instead of javelin_render_tag() so sigils are
not converted correctly.

Test Plan:
Opened an inline comment in differential, got focus on the <textarea />

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 259
This commit is contained in:
epriestley 2011-05-10 11:24:06 -07:00
parent d5dfa5faf5
commit e32fd1a871
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/view/dialog/AphrontDialogView.php
View file

@ -83,7 +83,7 @@ class AphrontDialogView extends AphrontView {
$buttons = array(); $buttons = array();
if ($this->submitButton) { if ($this->submitButton) {
$buttons[] = phutil_render_tag( $buttons[] = javelin_render_tag(
'button', 'button',
array( array(
'name' => '__submit__', 'name' => '__submit__',