From e333017c3e320df0811a30a8b419c38c02a851e3 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 2 Oct 2014 12:33:43 -0700
Subject: [PATCH] Strip email signatures from Mailbox

Summary: thanks mailbox

Test Plan: unit tests

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10629
---
 .../metamta/parser/PhabricatorMetaMTAEmailBodyParser.php   | 7 +++++++
 .../PhabricatorMetaMTAEmailBodyParserTestCase.php          | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php b/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
index a53d9bf089..7ee2e02485 100644
--- a/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
+++ b/src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
@@ -103,6 +103,13 @@ final class PhabricatorMetaMTAEmailBodyParser {
       '',
       $body);
 
+    // Mailbox seems to make an attempt to comply with the "standard" but
+    // omits the leading newline and uses an em dash?
+    $body = preg_replace(
+      "/\s*\xE2\x80\x94 \nSent from Mailbox\s*\z/su",
+      '',
+      $body);
+
     // HTC Mail application (mobile)
     $body = preg_replace(
       '/^\s*^Sent from my HTC smartphone.*/sm',
diff --git a/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php b/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
index 4a9c2cc845..94473f498c 100644
--- a/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
+++ b/src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php
@@ -66,6 +66,7 @@ EOEMAIL;
 
   private function getEmailBodies() {
     $trailing_space = ' ';
+    $emdash = "\xE2\x80\x94";
 
     return array(
 <<<EOEMAIL
@@ -176,6 +177,11 @@ OKAY
 > -----Original Message-----
 >
 > ...
+EOMAIL
+,
+<<<EOMAIL
+OKAY {$emdash}{$trailing_space}
+Sent from Mailbox
 EOMAIL
     );
   }