From e40bcc8d2bae91d2fd05d3d369033d8edc60f7e0 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Fri, 16 Nov 2012 07:22:31 -0800 Subject: [PATCH] update documentation for storage changes w/ .php files Summary: no schema changes allowed in the .php files Test Plan: viewed doc -- looked good. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2059 Differential Revision: https://secure.phabricator.com/D3966 --- src/docs/developer/database.diviner | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/docs/developer/database.diviner b/src/docs/developer/database.diviner index a2974a6bbc..d9751d41bf 100644 --- a/src/docs/developer/database.diviner +++ b/src/docs/developer/database.diviner @@ -151,7 +151,11 @@ such as PHID columns. Otherwise, use `COLLATE utf8_general_ci`. add your patch to @{method@phabricator:PhabricatorBuiltinPatchList::getPatches}. # Run `bin/storage/upgrade`. -It is also possible to create more complex patch in PHP. +It is also possible to create more complex patches in PHP for data migration +(due to schema changes or otherwise.) However, the schema changes themselves +should be done in separate `.sql` files. Order can be guaranteed by editing +`src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php` +appropriately. See the [[https://secure.phabricator.com/rPb39175342dc5bee0c2246b05fa277e76a7e96ed3