From e434edc4558a0b84a4dc8087d51e71704d9f7b94 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 27 May 2013 13:32:46 -0700
Subject: [PATCH] Make "arc tasks --unassigned" actually find unassigned tasks

Summary:
Ref T3201. D6009 added this flag, but I don't think it actually works as advertised? We either need a Conduit patch to interpret `null` as `upforgrabs` (which seems 100% reasonable to me) or this (which is kind of nasty).

@garoevans, was there a Phabricator-side diff for the conduit part that just got dropped? I'll probably replace this with that if not, but figured I'd check before I poke anything.

Test Plan: Ran `arc diff --unassigned`

Reviewers: garoevans

Reviewed By: garoevans

CC: aran

Maniphest Tasks: T3201

Differential Revision: https://secure.phabricator.com/D6062
---
 src/applications/maniphest/ManiphestTaskQuery.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/maniphest/ManiphestTaskQuery.php b/src/applications/maniphest/ManiphestTaskQuery.php
index b52c9f5d31..9c849f7404 100644
--- a/src/applications/maniphest/ManiphestTaskQuery.php
+++ b/src/applications/maniphest/ManiphestTaskQuery.php
@@ -88,7 +88,7 @@ final class ManiphestTaskQuery extends PhabricatorQuery {
   public function withOwners(array $owners) {
     $this->includeUnowned = false;
     foreach ($owners as $k => $phid) {
-      if ($phid == ManiphestTaskOwner::OWNER_UP_FOR_GRABS) {
+      if ($phid == ManiphestTaskOwner::OWNER_UP_FOR_GRABS || $phid === null) {
         $this->includeUnowned = true;
         unset($owners[$k]);
         break;