Fix method visibility for PhabricatorApplicationSearchEngine methods

Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within the `PhabricatorApplicationSearchEngine` class.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11242

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

@@ -31,7 +31,7 @@ final class AlmanacDeviceSearchEngine
     return '/almanac/device/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Devices'),
     );

src/applications/almanac/query/AlmanacNetworkSearchEngine.php

@@ -31,7 +31,7 @@ final class AlmanacNetworkSearchEngine
     return '/almanac/network/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Networks'),
     );

src/applications/almanac/query/AlmanacServiceSearchEngine.php

@@ -31,7 +31,7 @@ final class AlmanacServiceSearchEngine
     return '/almanac/service/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Services'),
     );

src/applications/audit/query/PhabricatorCommitSearchEngine.php

@@ -122,7 +122,7 @@ final class PhabricatorCommitSearchEngine
     return '/audit/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorCalendarEventSearchEngine
     return pht('Calendar Events');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorCalendarApplication';
   }
 
@@ -143,7 +143,7 @@ final class PhabricatorCalendarEventSearchEngine
     return '/calendar/event/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'upcoming' => pht('Upcoming Events'),
       'all'      => pht('All Events'),

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorConduitSearchEngine
     return pht('Conduit Methods');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorConduitApplication';
   }
 
@@ -112,7 +112,7 @@ final class PhabricatorConduitSearchEngine
     return '/conduit/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'modern' => pht('Modern Methods'),
       'all'    => pht('All Methods'),

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorCountdownSearchEngine
     return pht('Countdowns');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorCountdownApplication';
   }
 
@@ -68,7 +68,7 @@ final class PhabricatorCountdownSearchEngine
     return '/countdown/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'upcoming' => pht('Upcoming'),
       'all' => pht('All'),

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorDashboardPanelSearchEngine
     return pht('Dashboard Panels');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDashboardApplication';
   }
 
@@ -59,7 +59,7 @@ final class PhabricatorDashboardPanelSearchEngine
     return '/dashboard/panel/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active Panels'),
       'all'    => pht('All Panels'),

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorDashboardSearchEngine
     return pht('Dashboards');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDashboardApplication';
   }
 
@@ -29,7 +29,7 @@ final class PhabricatorDashboardSearchEngine
     return '/dashboard/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Dashboards'),
     );

src/applications/differential/query/DifferentialRevisionSearchEngine.php

@@ -7,7 +7,7 @@ final class DifferentialRevisionSearchEngine
     return pht('Differential Revisions');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDifferentialApplication';
   }
 
@@ -200,7 +200,7 @@ final class DifferentialRevisionSearchEngine
     return '/differential/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/diviner/query/DivinerAtomSearchEngine.php

@@ -6,7 +6,7 @@ final class DivinerAtomSearchEngine extends PhabricatorApplicationSearchEngine {
     return pht('Documentation Atoms');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDivinerApplication';
   }
 
@@ -73,7 +73,7 @@ final class DivinerAtomSearchEngine extends PhabricatorApplicationSearchEngine {
     return '/diviner/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All'),
     );

src/applications/drydock/query/DrydockBlueprintSearchEngine.php

@@ -7,7 +7,7 @@ final class DrydockBlueprintSearchEngine
     return pht('Drydock Blueprints');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDrydockApplication';
   }
 
@@ -27,7 +27,7 @@ final class DrydockBlueprintSearchEngine
     return '/drydock/blueprint/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Blueprints'),
     );
@@ -45,7 +45,7 @@ final class DrydockBlueprintSearchEngine
     return parent::buildSavedQueryFromBuiltin($query_key);
   }
 
-  public function renderResultList(
+  protected function renderResultList(
     array $blueprints,
     PhabricatorSavedQuery $query,
     array $handles) {

src/applications/drydock/query/DrydockLeaseSearchEngine.php

@@ -7,7 +7,7 @@ final class DrydockLeaseSearchEngine
     return pht('Drydock Leases');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDrydockApplication';
   }
 
@@ -57,7 +57,7 @@ final class DrydockLeaseSearchEngine
     return '/drydock/lease/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active Leases'),
       'all' => pht('All Leases'),

src/applications/drydock/query/DrydockLogSearchEngine.php

@@ -6,7 +6,7 @@ final class DrydockLogSearchEngine extends PhabricatorApplicationSearchEngine {
     return pht('Drydock Logs');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDrydockApplication';
   }
 
@@ -26,7 +26,7 @@ final class DrydockLogSearchEngine extends PhabricatorApplicationSearchEngine {
     return '/drydock/log/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Logs'),
     );

src/applications/drydock/query/DrydockResourceSearchEngine.php

@@ -7,7 +7,7 @@ final class DrydockResourceSearchEngine
     return pht('Drydock Resources');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDrydockApplication';
   }
 
@@ -56,7 +56,7 @@ final class DrydockResourceSearchEngine
     return '/drydock/resource/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active Resources'),
       'all' => pht('All Resources'),

src/applications/feed/query/PhabricatorFeedSearchEngine.php

@@ -101,7 +101,7 @@ final class PhabricatorFeedSearchEngine
     return '/feed/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Stories'),
     );

src/applications/files/query/PhabricatorFileSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorFileSearchEngine
     return pht('Files');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorFilesApplication';
   }
 
@@ -86,7 +86,7 @@ final class PhabricatorFileSearchEngine
     return '/file/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/flag/query/PhabricatorFlagSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorFlagSearchEngine
     return pht('Flags');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorFlagsApplication';
   }
 
@@ -71,7 +71,7 @@ final class PhabricatorFlagSearchEngine
     return '/flag/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('Flagged'),
     );

src/applications/fund/query/FundBackerSearchEngine.php

@@ -18,7 +18,7 @@ final class FundBackerSearchEngine
     return pht('Fund Backers');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorFundApplication';
   }
 
@@ -86,7 +86,7 @@ final class FundBackerSearchEngine
     }
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
     $names['all'] = pht('All Backers');
 

src/applications/fund/query/FundInitiativeSearchEngine.php

@@ -7,7 +7,7 @@ final class FundInitiativeSearchEngine
     return pht('Fund Initiatives');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorFundApplication';
   }
 
@@ -86,7 +86,7 @@ final class FundInitiativeSearchEngine
     return '/fund/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     $names['open'] = pht('Open Initiatives');

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

@@ -7,7 +7,7 @@ final class HarbormasterBuildPlanSearchEngine
     return pht('Harbormaster Build Plans');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorHarbormasterApplication';
   }
 
@@ -58,7 +58,7 @@ final class HarbormasterBuildPlanSearchEngine
     return '/harbormaster/plan/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active Plans'),
       'all' => pht('All Plans'),

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

@@ -7,7 +7,7 @@ final class HarbormasterBuildableSearchEngine
     return pht('Harbormaster Buildables');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorHarbormasterApplication';
   }
 
@@ -159,7 +159,7 @@ final class HarbormasterBuildableSearchEngine
     return '/harbormaster/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Buildables'),
     );

src/applications/herald/query/HeraldRuleSearchEngine.php

@@ -6,7 +6,7 @@ final class HeraldRuleSearchEngine extends PhabricatorApplicationSearchEngine {
     return pht('Herald Rules');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorHeraldApplication';
   }
 
@@ -103,7 +103,7 @@ final class HeraldRuleSearchEngine extends PhabricatorApplicationSearchEngine {
     return '/herald/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/herald/query/HeraldTranscriptSearchEngine.php

@@ -7,7 +7,7 @@ final class HeraldTranscriptSearchEngine
     return pht('Herald Transcripts');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorHeraldApplication';
   }
 
@@ -74,7 +74,7 @@ final class HeraldTranscriptSearchEngine
     return '/herald/transcript/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All'),
     );

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

@@ -7,7 +7,7 @@ final class LegalpadDocumentSearchEngine
     return pht('Legalpad Documents');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorLegalpadApplication';
   }
 
@@ -120,7 +120,7 @@ final class LegalpadDocumentSearchEngine
     return '/legalpad/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

@@ -9,7 +9,7 @@ final class LegalpadDocumentSignatureSearchEngine
     return pht('Legalpad Signatures');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorLegalpadApplication';
   }
 
@@ -123,7 +123,7 @@ final class LegalpadDocumentSignatureSearchEngine
     }
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Signatures'),
     );

src/applications/macro/query/PhabricatorMacroSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorMacroSearchEngine
     return pht('Macros');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorMacroApplication';
   }
 
@@ -128,7 +128,7 @@ final class PhabricatorMacroSearchEngine
     return '/macro/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'active'  => pht('Active'),
       'all'     => pht('All'),

src/applications/mailinglists/query/PhabricatorMailingListSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorMailingListSearchEngine
     return pht('Mailing Lists');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorMailingListsApplication';
   }
 
@@ -38,7 +38,7 @@ final class PhabricatorMailingListSearchEngine
     return '/mailinglists/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Lists'),
     );

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

@@ -34,7 +34,7 @@ final class ManiphestTaskSearchEngine
     return pht('Tasks');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorManiphestApplication';
   }
 
@@ -437,7 +437,7 @@ final class ManiphestTaskSearchEngine
     return '/maniphest/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/meta/query/PhabricatorAppSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorAppSearchEngine
     return pht('Applications');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorApplicationsApplication';
   }
 
@@ -136,7 +136,7 @@ final class PhabricatorAppSearchEngine
     return '/applications/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'launcher' => pht('Launcher'),
       'all' => pht('All Applications'),

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorNotificationSearchEngine
     return pht('Notifications');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorNotificationsApplication';
   }
 
@@ -52,7 +52,7 @@ final class PhabricatorNotificationSearchEngine
     return '/notification/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
 
     $names = array(
       'all' => pht('All Notifications'),

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorOAuthServerClientSearchEngine
     return pht('OAuth Clients');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorOAuthServerApplication';
   }
 
@@ -55,7 +55,7 @@ final class PhabricatorOAuthServerClientSearchEngine
     return '/oauthserver/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

@@ -7,7 +7,7 @@ final class PassphraseCredentialSearchEngine
     return pht('Passphrase Credentials');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPassphraseApplication';
   }
 
@@ -67,7 +67,7 @@ final class PassphraseCredentialSearchEngine
     return '/passphrase/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active Credentials'),
       'all' => pht('All Credentials'),

src/applications/paste/query/PhabricatorPasteSearchEngine.php

@@ -98,7 +98,7 @@ final class PhabricatorPasteSearchEngine
     return '/paste/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Pastes'),
     );

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorPeopleLogSearchEngine
     return pht('Account Activity');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPeopleApplication';
   }
 
@@ -152,7 +152,7 @@ final class PhabricatorPeopleLogSearchEngine
     return '/people/logs/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All'),
     );

src/applications/people/query/PhabricatorPeopleSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorPeopleSearchEngine
     return pht('Users');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPeopleApplication';
   }
 
@@ -163,7 +163,7 @@ final class PhabricatorPeopleSearchEngine
     return '/people/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All'),
     );

src/applications/pholio/query/PholioMockSearchEngine.php

@@ -6,7 +6,7 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine {
     return pht('Pholio Mocks');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPholioApplication';
   }
 
@@ -71,7 +71,7 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine {
     return '/pholio/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'open' => pht('Open Mocks'),
       'all' => pht('All Mocks'),

src/applications/phortune/query/PhortuneCartSearchEngine.php

@@ -102,7 +102,7 @@ final class PhortuneCartSearchEngine
     }
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Orders'),
     );

src/applications/phortune/query/PhortuneChargeSearchEngine.php

@@ -69,7 +69,7 @@ final class PhortuneChargeSearchEngine
     }
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Charges'),
     );

src/applications/phortune/query/PhortuneMerchantSearchEngine.php

@@ -27,7 +27,7 @@ final class PhortuneMerchantSearchEngine
     return '/phortune/merchant/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'all' => pht('All Merchants'),
     );

src/applications/phrequent/query/PhrequentSearchEngine.php

@@ -6,7 +6,7 @@ final class PhrequentSearchEngine extends PhabricatorApplicationSearchEngine {
     return pht('Phrequent Time');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPhrequentApplication';
   }
 
@@ -91,7 +91,7 @@ final class PhrequentSearchEngine extends PhabricatorApplicationSearchEngine {
     return '/phrequent/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'tracking' => pht('Currently Tracking'),
       'all' => pht('All Tracked'),

src/applications/phriction/query/PhrictionSearchEngine.php

@@ -59,7 +59,7 @@ final class PhrictionSearchEngine
     return '/phriction/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'active' => pht('Active'),
       'updated' => pht('Updated'),

src/applications/ponder/query/PonderQuestionSearchEngine.php

@@ -7,7 +7,7 @@ final class PonderQuestionSearchEngine
     return pht('Ponder Questions');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorPonderApplication';
   }
 
@@ -95,7 +95,7 @@ final class PonderQuestionSearchEngine
     return '/ponder/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'open' => pht('Open Questions'),
       'all' => pht('All Questions'),

src/applications/project/query/PhabricatorProjectSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorProjectSearchEngine
     return pht('Projects');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorProjectApplication';
   }
 
@@ -145,7 +145,7 @@ final class PhabricatorProjectSearchEngine
     return '/project/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array();
 
     if ($this->requireViewer()->isLoggedIn()) {

src/applications/releeph/query/ReleephBranchSearchEngine.php

@@ -56,7 +56,7 @@ final class ReleephBranchSearchEngine
     return '/releeph/product/'.$this->getProduct()->getID().'/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'open' => pht('Open'),
       'all' => pht('All'),

src/applications/releeph/query/ReleephProductSearchEngine.php

@@ -7,7 +7,7 @@ final class ReleephProductSearchEngine
     return pht('Releeph Products');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorReleephApplication';
   }
 
@@ -49,7 +49,7 @@ final class ReleephProductSearchEngine
     return '/releeph/project/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'active' => pht('Active'),
       'all' => pht('All'),

src/applications/releeph/query/ReleephRequestSearchEngine.php

@@ -94,7 +94,7 @@ final class ReleephRequestSearchEngine
     return $this->baseURI.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'open' => pht('Open Requests'),
       'all' => pht('All Requests'),

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorRepositoryPushLogSearchEngine
     return pht('Push Logs');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDiffusionApplication';
   }
 
@@ -90,7 +90,7 @@ final class PhabricatorRepositoryPushLogSearchEngine
     return '/diffusion/pushlog/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Push Logs'),
     );

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorRepositorySearchEngine
     return pht('Repositories');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorDiffusionApplication';
   }
 
@@ -149,7 +149,7 @@ final class PhabricatorRepositorySearchEngine
     return '/diffusion/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'active' => pht('Active Repositories'),
       'all' => pht('All Repositories'),

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

@@ -7,7 +7,7 @@ final class PhabricatorSearchApplicationSearchEngine
     return pht('Fulltext Results');
   }
 
-  public function getApplicationClassName() {
+  protected function getApplicationClassName() {
     return 'PhabricatorSearchApplication';
   }
 
@@ -169,7 +169,7 @@ final class PhabricatorSearchApplicationSearchEngine
     return '/search/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     return array(
       'all' => pht('All Documents'),
       'open' => pht('Open Documents'),

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

@@ -85,7 +85,7 @@ final class PhabricatorSlowvoteSearchEngine
     return '/vote/'.$path;
   }
 
-  public function getBuiltinQueryNames() {
+  protected function getBuiltinQueryNames() {
     $names = array(
       'open' => pht('Open Polls'),
       'all' => pht('All Polls'),
@@ -119,7 +119,7 @@ final class PhabricatorSlowvoteSearchEngine
     return parent::buildSavedQueryFromBuiltin($query_key);
   }
 
-  public function getRequiredHandlePHIDsForResultList(
+  protected function getRequiredHandlePHIDsForResultList(
     array $polls,
     PhabricatorSavedQuery $query) {
     return mpull($polls, 'getAuthorPHID');