1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 19:22:42 +01:00

In Differential, filter repository operations to just "Land" operations again

Summary:
Reverts D18276. See PHI18 for discussion. The additional rules here (roughly, "only show the first successful operation") didn't actually work out for the other types of operations.

This is all just figuring out a stopgap, T12935 and other changes should eventually provide real pathways here.

Test Plan: Straight revert.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18281
This commit is contained in:
epriestley 2017-07-26 10:09:36 -07:00
parent e7f94d7528
commit e47f85cd98

View file

@ -1051,14 +1051,14 @@ final class DifferentialRevisionViewController extends DifferentialController {
return null; return null;
} }
// NOTE: The upstream currently supports only "Land" operations, but
// third parties have other operations (see PHI18). For now, we show any
// operation that exists. We'll refine this in the future.
$operations = id(new DrydockRepositoryOperationQuery()) $operations = id(new DrydockRepositoryOperationQuery())
->setViewer($viewer) ->setViewer($viewer)
->withObjectPHIDs(array($revision->getPHID())) ->withObjectPHIDs(array($revision->getPHID()))
->withIsDismissed(false) ->withIsDismissed(false)
->withOperationTypes(
array(
DrydockLandRepositoryOperation::OPCONST,
))
->execute(); ->execute();
if (!$operations) { if (!$operations) {
return null; return null;