mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
fix Conpherence sorting
Summary: this broke when I moved sorting to the editor. Turns out you can't have custom hooks for the comment transaction, and thus I couldn't update participation inside the editor. This fixes this by removing the empty switch statement for the transaction type inside the parent class editor. This should have no effect other than fixing Conpherence. Note that conpherences will need another message, etc for a given conphernece to fix itself. Test Plan: Conpherence threads were updated properly! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2399 Differential Revision: https://secure.phabricator.com/D4817
This commit is contained in:
parent
a211f97737
commit
e4a0c17079
1 changed files with 2 additions and 8 deletions
|
@ -153,25 +153,20 @@ abstract class PhabricatorApplicationTransactionEditor
|
|||
PhabricatorLiskDAO $object,
|
||||
PhabricatorApplicationTransaction $xaction) {
|
||||
switch ($xaction->getTransactionType()) {
|
||||
case PhabricatorTransactions::TYPE_COMMENT:
|
||||
break;
|
||||
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
||||
$object->setViewPolicy($xaction->getNewValue());
|
||||
break;
|
||||
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
||||
$object->setEditPolicy($xaction->getNewValue());
|
||||
break;
|
||||
default:
|
||||
return $this->applyCustomInternalTransaction($object, $xaction);
|
||||
}
|
||||
return $this->applyCustomInternalTransaction($object, $xaction);
|
||||
}
|
||||
|
||||
private function applyExternalEffects(
|
||||
PhabricatorLiskDAO $object,
|
||||
PhabricatorApplicationTransaction $xaction) {
|
||||
switch ($xaction->getTransactionType()) {
|
||||
case PhabricatorTransactions::TYPE_COMMENT:
|
||||
break;
|
||||
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
||||
$subeditor = id(new PhabricatorSubscriptionsEditor())
|
||||
->setObject($object)
|
||||
|
@ -179,9 +174,8 @@ abstract class PhabricatorApplicationTransactionEditor
|
|||
->subscribeExplicit($xaction->getNewValue())
|
||||
->save();
|
||||
break;
|
||||
default:
|
||||
return $this->applyCustomExternalTransaction($object, $xaction);
|
||||
}
|
||||
return $this->applyCustomExternalTransaction($object, $xaction);
|
||||
}
|
||||
|
||||
protected function applyCustomInternalTransaction(
|
||||
|
|
Loading…
Reference in a new issue