revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

fix Conpherence sorting

Browse source 
Summary: this broke when I moved sorting to the editor. Turns out you can't have custom hooks for the comment transaction, and thus I couldn't update participation inside the editor. This fixes this by removing the empty switch statement for the transaction type inside the parent class editor. This should have no effect other than fixing Conpherence. Note that conpherences will need another message, etc for a given conphernece to fix itself.

Test Plan: Conpherence threads were updated properly!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2399

Differential Revision: https://secure.phabricator.com/D4817
This commit is contained in:
Bob Trahan 2013-02-04 19:05:50 -08:00
parent a211f97737
commit e4a0c17079
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -153,25 +153,20 @@ abstract class PhabricatorApplicationTransactionEditor
PhabricatorLiskDAO $object, PhabricatorLiskDAO $object,
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case PhabricatorTransactions::TYPE_COMMENT:
break;
case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_VIEW_POLICY:
$object->setViewPolicy($xaction->getNewValue()); $object->setViewPolicy($xaction->getNewValue());
break; break;
case PhabricatorTransactions::TYPE_EDIT_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY:
$object->setEditPolicy($xaction->getNewValue()); $object->setEditPolicy($xaction->getNewValue());
break; break;
default:
return $this->applyCustomInternalTransaction($object, $xaction);
} }
return $this->applyCustomInternalTransaction($object, $xaction);
} }
private function applyExternalEffects( private function applyExternalEffects(
PhabricatorLiskDAO $object, PhabricatorLiskDAO $object,
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case PhabricatorTransactions::TYPE_COMMENT:
break;
case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_SUBSCRIBERS:
$subeditor = id(new PhabricatorSubscriptionsEditor()) $subeditor = id(new PhabricatorSubscriptionsEditor())
->setObject($object) ->setObject($object)
@ -179,9 +174,8 @@ abstract class PhabricatorApplicationTransactionEditor
->subscribeExplicit($xaction->getNewValue()) ->subscribeExplicit($xaction->getNewValue())
->save(); ->save();
break; break;
default:
return $this->applyCustomExternalTransaction($object, $xaction);
} }
return $this->applyCustomExternalTransaction($object, $xaction);
} }
protected function applyCustomInternalTransaction( protected function applyCustomInternalTransaction(