From e4d38592ceb4926201c8a87fdeddc6b79d13a43f Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 25 Jun 2014 20:55:10 -0700 Subject: [PATCH] Touch up hidden panel colors Summary: Adds a red border, panels love borders. Test Plan: Hide/Unhide {F170300} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9739 --- resources/celerity/map.php | 4 ++-- src/view/phui/PHUIWorkpanelView.php | 6 +++++- webroot/rsrc/css/phui/phui-workpanel-view.css | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 0e2728560d..6e377b275a 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -146,7 +146,7 @@ return array( 'rsrc/css/phui/phui-text.css' => '23e9b4b7', 'rsrc/css/phui/phui-timeline-view.css' => 'bbd990d0', 'rsrc/css/phui/phui-workboard-view.css' => '2bf82d00', - 'rsrc/css/phui/phui-workpanel-view.css' => 'a8d0273b', + 'rsrc/css/phui/phui-workpanel-view.css' => 'ed2a2162', 'rsrc/css/sprite-apps-large.css' => '12ea1ced', 'rsrc/css/sprite-apps.css' => '37ee4f4e', 'rsrc/css/sprite-conpherence.css' => '3b4a0487', @@ -791,7 +791,7 @@ return array( 'phui-text-css' => '23e9b4b7', 'phui-timeline-view-css' => 'bbd990d0', 'phui-workboard-view-css' => '2bf82d00', - 'phui-workpanel-view-css' => 'a8d0273b', + 'phui-workpanel-view-css' => 'ed2a2162', 'phuix-action-list-view' => 'b5c256b8', 'phuix-action-view' => '6e8cefa4', 'phuix-dropdown-menu' => 'bd4c8dca', diff --git a/src/view/phui/PHUIWorkpanelView.php b/src/view/phui/PHUIWorkpanelView.php index 500791c1e8..bde58eb0f2 100644 --- a/src/view/phui/PHUIWorkpanelView.php +++ b/src/view/phui/PHUIWorkpanelView.php @@ -48,6 +48,8 @@ final class PHUIWorkpanelView extends AphrontTagView { public function getTagContent() { require_celerity_resource('phui-workpanel-view-css'); + $classes = array(); + $classes[] = 'phui-workpanel-view-inner'; $footer = ''; if ($this->footerAction) { $footer_tag = $this->footerAction; @@ -75,6 +77,8 @@ final class PHUIWorkpanelView extends AphrontTagView { $header->addAction($this->headerAction); } + $classes[] = 'phui-workpanel-'.$this->headerColor; + $body = phutil_tag( 'div', array( @@ -85,7 +89,7 @@ final class PHUIWorkpanelView extends AphrontTagView { $view = phutil_tag( 'div', array( - 'class' => 'phui-workpanel-view-inner', + 'class' => implode(' ', $classes), ), array( $header, diff --git a/webroot/rsrc/css/phui/phui-workpanel-view.css b/webroot/rsrc/css/phui/phui-workpanel-view.css index be114f394d..5606ce396a 100644 --- a/webroot/rsrc/css/phui/phui-workpanel-view.css +++ b/webroot/rsrc/css/phui/phui-workpanel-view.css @@ -90,6 +90,12 @@ background: rgba(255,255,255,.7); } +.phui-workpanel-view .phui-workpanel-lightred .phui-action-header { + border-top: 1px solid {$redborder}; + border-left: 1px solid {$redborder}; + border-right: 1px solid {$redborder}; +} + /* - Workpanel Cards ----------------------------------------------------------- Slight display changes for how cards work in tight spaces