mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Fix fatal in rendering Phriction "Moved Away" stories
Summary: Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline). Update the rendering to work. The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least. Test Plan: - Moved page "X" to "Y". - Viewed the old page "X". - Before patch: bad timeline story would fatal rendering. - After patch: story renders, at least, just not great. Reviewers: amckinley Maniphest Tasks: T13202 Differential Revision: https://secure.phabricator.com/D19682
This commit is contained in:
parent
0167f357b7
commit
e5c6a5749a
1 changed files with 4 additions and 4 deletions
|
@ -38,19 +38,19 @@ final class PhrictionDocumentMoveAwayTransaction
|
|||
$new = $this->getNewValue();
|
||||
|
||||
return pht(
|
||||
'%s moved this document to %s',
|
||||
'%s moved this document to %s.',
|
||||
$this->renderAuthor(),
|
||||
$this->renderHandleLink($new['phid']));
|
||||
$this->renderObject($new['phid']));
|
||||
}
|
||||
|
||||
public function getTitleForFeed() {
|
||||
$new = $this->getNewValue();
|
||||
|
||||
return pht(
|
||||
'%s moved %s to %s',
|
||||
'%s moved %s to %s.',
|
||||
$this->renderAuthor(),
|
||||
$this->renderObject(),
|
||||
$this->renderHandleLink($new['phid']));
|
||||
$this->renderObject($new['phid']));
|
||||
}
|
||||
|
||||
public function getIcon() {
|
||||
|
|
Loading…
Reference in a new issue