From e5caf4333e5ebc8ebcb85b128193e56936bb81cf Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Mon, 8 May 2023 13:20:00 +0200 Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception which blocks creating a blog post Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15357 Test Plan: Applied this change and created blog post at `/phame/post/view/3/blogpost/` rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15357 Differential Revision: https://we.phorge.it/D25196 --- src/applications/phame/storage/PhamePost.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php index 21149f07c2..5291bcd465 100644 --- a/src/applications/phame/storage/PhamePost.php +++ b/src/applications/phame/storage/PhamePost.php @@ -67,7 +67,8 @@ final class PhamePost extends PhameDAO $blog = $this->getBlog(); $is_draft = $this->isDraft(); $is_archived = $this->isArchived(); - if (strlen($blog->getDomain()) && !$is_draft && !$is_archived) { + if (phutil_nonempty_string($blog->getDomain()) && + !$is_draft && !$is_archived) { return $this->getExternalLiveURI(); } else { return $this->getInternalLiveURI();