From e5e3617e46c5d561ab9e5419a571bd0a823c27db Mon Sep 17 00:00:00 2001 From: vrana Date: Fri, 28 Sep 2012 16:41:39 -0700 Subject: [PATCH] Use ?view= in Blame previous but not in line link Summary: I didn't notice that D3494 is revert of D3453. Test Plan: Checked both line and Blame previous links. Reviewers: epriestley, fdoemges Reviewed By: fdoemges CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3566 --- .../diffusion/controller/DiffusionBrowseFileController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php index 96048cadf0..12ddf2e6ca 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -469,7 +469,6 @@ final class DiffusionBrowseFileController extends DiffusionController { 'action' => 'browse', 'line' => $line['line'], 'stable' => true, - 'params' => array('view' => 'blame'), )); $blame = array(); @@ -540,10 +539,11 @@ final class DiffusionBrowseFileController extends DiffusionController { 'D'.$revision_id); } + $uri = $line_href->alter('before', $commit); $before_link = javelin_render_tag( 'a', array( - 'href' => $line_href->alter('before', $commit), + 'href' => $uri->setQueryParam('view', 'blame'), 'sigil' => 'has-tooltip', 'meta' => array( 'tip' => 'Skip Past This Commit',