From e5e5974d9fe1b7993733a6b5567dc4ea574e719e Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 19 Apr 2015 07:32:09 -0700 Subject: [PATCH] Give typeahead browse dialogs sensible titles Summary: Ref T4100. Let datasources specify a more meaningful title than the class name. Test Plan: Browsed some sources. Reviewers: btrahan, chad Reviewed By: chad Subscribers: chad, epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12469 --- .../almanac/typeahead/AlmanacInterfaceDatasource.php | 4 ++++ .../almanac/typeahead/AlmanacServiceDatasource.php | 4 ++++ .../typeahead/DiffusionArcanistProjectDatasource.php | 4 ++++ .../diffusion/typeahead/DiffusionAuditorDatasource.php | 4 ++++ .../diffusion/typeahead/DiffusionRepositoryDatasource.php | 4 ++++ .../diffusion/typeahead/DiffusionSymbolDatasource.php | 4 ++++ .../typeahead/HarbormasterBuildDependencyDatasource.php | 4 ++++ .../typeahead/HarbormasterBuildPlanDatasource.php | 4 ++++ .../legalpad/typeahead/LegalpadDocumentDatasource.php | 4 ++++ .../macro/typeahead/PhabricatorMacroDatasource.php | 4 ++++ .../typeahead/PhabricatorMailingListDatasource.php | 4 ++++ .../maniphest/typeahead/ManiphestTaskPriorityDatasource.php | 4 ++++ .../maniphest/typeahead/ManiphestTaskStatusDatasource.php | 4 ++++ .../meta/typeahead/PhabricatorApplicationDatasource.php | 4 ++++ .../PhabricatorMetaMTAApplicationEmailDatasource.php | 4 ++++ .../typeahead/PhabricatorMetaMTAMailableDatasource.php | 4 ++++ .../owners/typeahead/PhabricatorOwnersPackageDatasource.php | 4 ++++ .../people/typeahead/PhabricatorPeopleDatasource.php | 4 ++++ .../people/typeahead/PhabricatorViewerDatasource.php | 4 ++++ .../project/typeahead/PhabricatorProjectDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectLogicalAndDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectLogicalDatasource.php | 6 +++++- .../typeahead/PhabricatorProjectLogicalOrNotDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectLogicalUserDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectLogicalViewerDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectMembersDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectNoProjectsDatasource.php | 4 ++++ .../typeahead/PhabricatorProjectOrUserDatasource.php | 4 ++++ .../search/typeahead/PhabricatorSearchDatasource.php | 4 ++++ .../PhabricatorTypeaheadModularDatasourceController.php | 2 +- .../typeahead/datasource/PhabricatorTypeaheadDatasource.php | 5 +++++ .../datasource/PhabricatorTypeaheadMonogramDatasource.php | 4 ++++ .../datasource/PhabricatorTypeaheadNoOwnerDatasource.php | 4 ++++ .../datasource/PhabricatorTypeaheadOwnerDatasource.php | 4 ++++ .../PhabricatorTypeaheadUserParameterizedDatasource.php | 6 +++++- 35 files changed, 140 insertions(+), 3 deletions(-) diff --git a/src/applications/almanac/typeahead/AlmanacInterfaceDatasource.php b/src/applications/almanac/typeahead/AlmanacInterfaceDatasource.php index 73ae32938b..a5f46ddfb0 100644 --- a/src/applications/almanac/typeahead/AlmanacInterfaceDatasource.php +++ b/src/applications/almanac/typeahead/AlmanacInterfaceDatasource.php @@ -9,6 +9,10 @@ final class AlmanacInterfaceDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Interfaces'); + } + public function getPlaceholderText() { return pht('Type an interface name...'); } diff --git a/src/applications/almanac/typeahead/AlmanacServiceDatasource.php b/src/applications/almanac/typeahead/AlmanacServiceDatasource.php index 4cc0d1376a..e5728e1c26 100644 --- a/src/applications/almanac/typeahead/AlmanacServiceDatasource.php +++ b/src/applications/almanac/typeahead/AlmanacServiceDatasource.php @@ -3,6 +3,10 @@ final class AlmanacServiceDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Services'); + } + public function getPlaceholderText() { return pht('Type a service name...'); } diff --git a/src/applications/diffusion/typeahead/DiffusionArcanistProjectDatasource.php b/src/applications/diffusion/typeahead/DiffusionArcanistProjectDatasource.php index ce77b56f9b..4f58acfa59 100644 --- a/src/applications/diffusion/typeahead/DiffusionArcanistProjectDatasource.php +++ b/src/applications/diffusion/typeahead/DiffusionArcanistProjectDatasource.php @@ -8,6 +8,10 @@ final class DiffusionArcanistProjectDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Arcanist Projects'); + } + public function getPlaceholderText() { return pht('Type an arcanist project name...'); } diff --git a/src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php b/src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php index 471c8a15b7..54c3aa72d9 100644 --- a/src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php +++ b/src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php @@ -3,6 +3,10 @@ final class DiffusionAuditorDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Auditors'); + } + public function getPlaceholderText() { return pht('Type a user, project or package name...'); } diff --git a/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php b/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php index 995a413d97..4c2b8e1fb0 100644 --- a/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php +++ b/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php @@ -3,6 +3,10 @@ final class DiffusionRepositoryDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Repositories'); + } + public function getPlaceholderText() { return pht('Type a repository name...'); } diff --git a/src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php b/src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php index 0203ff2971..be7a084457 100644 --- a/src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php +++ b/src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php @@ -9,6 +9,10 @@ final class DiffusionSymbolDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Symbols'); + } + public function getPlaceholderText() { return pht('Type a symbol name...'); } diff --git a/src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php b/src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php index 997e129bb3..08b0be774e 100644 --- a/src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php +++ b/src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php @@ -8,6 +8,10 @@ final class HarbormasterBuildDependencyDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Dependencies'); + } + public function getPlaceholderText() { return pht('Type another build step name...'); } diff --git a/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php b/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php index ceb4a1ff10..cf5b815c57 100644 --- a/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php +++ b/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php @@ -3,6 +3,10 @@ final class HarbormasterBuildPlanDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Build Plans'); + } + public function getPlaceholderText() { return pht('Type a build plan name...'); } diff --git a/src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php b/src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php index a536843d0b..a0117ee7b0 100644 --- a/src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php +++ b/src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php @@ -7,6 +7,10 @@ final class LegalpadDocumentDatasource extends PhabricatorTypeaheadDatasource { return false; } + public function getBrowseTitle() { + return pht('Browse Documents'); + } + public function getPlaceholderText() { return pht('Type a document name...'); } diff --git a/src/applications/macro/typeahead/PhabricatorMacroDatasource.php b/src/applications/macro/typeahead/PhabricatorMacroDatasource.php index 1d978683cc..b7b7efd630 100644 --- a/src/applications/macro/typeahead/PhabricatorMacroDatasource.php +++ b/src/applications/macro/typeahead/PhabricatorMacroDatasource.php @@ -6,6 +6,10 @@ final class PhabricatorMacroDatasource extends PhabricatorTypeaheadDatasource { return pht('Type a macro name...'); } + public function getBrowseTitle() { + return pht('Browse Macros'); + } + public function getDatasourceApplicationClass() { return 'PhabricatorMacroApplication'; } diff --git a/src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php b/src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php index b9435e0b4a..cac292e1e5 100644 --- a/src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php +++ b/src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorMailingListDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Mailing Lists'); + } + public function getPlaceholderText() { return pht('Type a mailing list name...'); } diff --git a/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php b/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php index 568aa0636d..59c9a08042 100644 --- a/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php +++ b/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php @@ -3,6 +3,10 @@ final class ManiphestTaskPriorityDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Priorities'); + } + public function getPlaceholderText() { return pht('Type a task priority name...'); } diff --git a/src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php b/src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php index 27b3f90386..7ef047e72e 100644 --- a/src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php +++ b/src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php @@ -3,6 +3,10 @@ final class ManiphestTaskStatusDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Statuses'); + } + public function getPlaceholderText() { return pht('Type a task status name...'); } diff --git a/src/applications/meta/typeahead/PhabricatorApplicationDatasource.php b/src/applications/meta/typeahead/PhabricatorApplicationDatasource.php index 18b6683dfc..b6d4aa3f18 100644 --- a/src/applications/meta/typeahead/PhabricatorApplicationDatasource.php +++ b/src/applications/meta/typeahead/PhabricatorApplicationDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorApplicationDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Applications'); + } + public function getPlaceholderText() { return pht('Type an application name...'); } diff --git a/src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php b/src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php index 887aecfd80..62c1275c39 100644 --- a/src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php +++ b/src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php @@ -8,6 +8,10 @@ final class PhabricatorMetaMTAApplicationEmailDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Email Addresses'); + } + public function getPlaceholderText() { return pht('Type an application email address...'); } diff --git a/src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php b/src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php index 9d7e2cda7d..804e4498c0 100644 --- a/src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php +++ b/src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorMetaMTAMailableDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Subscribers'); + } + public function getPlaceholderText() { return pht('Type a user, project, or mailing list name...'); } diff --git a/src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php b/src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php index a8658549ec..73105f0908 100644 --- a/src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php +++ b/src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php @@ -8,6 +8,10 @@ final class PhabricatorOwnersPackageDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Packages'); + } + public function getPlaceholderText() { return pht('Type a package name...'); } diff --git a/src/applications/people/typeahead/PhabricatorPeopleDatasource.php b/src/applications/people/typeahead/PhabricatorPeopleDatasource.php index a2df2750ad..ab1f11cede 100644 --- a/src/applications/people/typeahead/PhabricatorPeopleDatasource.php +++ b/src/applications/people/typeahead/PhabricatorPeopleDatasource.php @@ -15,6 +15,10 @@ final class PhabricatorPeopleDatasource return $this; } + public function getBrowseTitle() { + return pht('Browse Users'); + } + public function getPlaceholderText() { return pht('Type a username...'); } diff --git a/src/applications/people/typeahead/PhabricatorViewerDatasource.php b/src/applications/people/typeahead/PhabricatorViewerDatasource.php index 92bd48bab0..ef4cbc3a1b 100644 --- a/src/applications/people/typeahead/PhabricatorViewerDatasource.php +++ b/src/applications/people/typeahead/PhabricatorViewerDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorViewerDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Viewer'); + } + public function getPlaceholderText() { return pht('Type viewer()...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectDatasource.php b/src/applications/project/typeahead/PhabricatorProjectDatasource.php index 0466ad9950..d38f6fc5b3 100644 --- a/src/applications/project/typeahead/PhabricatorProjectDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Projects'); + } + public function getPlaceholderText() { return pht('Type a project name...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php index 18748ce8a7..a3016820a0 100644 --- a/src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectLogicalAndDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Projects'); + } + public function getPlaceholderText() { return pht('Type a project name...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php index 17afb30c99..1bce988339 100644 --- a/src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php @@ -3,8 +3,12 @@ final class PhabricatorProjectLogicalDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Projects'); + } + public function getPlaceholderText() { - return pht('Type a project name or selector...'); + return pht('Type a project name or function...'); } public function getDatasourceApplicationClass() { diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php index c784179b7d..306e63f21a 100644 --- a/src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectLogicalOrNotDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Projects'); + } + public function getPlaceholderText() { return pht('Type any() or not()...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php index ed1ebdc782..06a638075d 100644 --- a/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectLogicalUserDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse User Projects'); + } + public function getPlaceholderText() { return pht('Type projects()...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php b/src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php index 7e76cd5762..4285462d54 100644 --- a/src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectLogicalViewerDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Viewer Projects'); + } + public function getPlaceholderText() { return pht('Type viewerprojects()...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php b/src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php index 4f8ee3e987..c96d006e56 100644 --- a/src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectMembersDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Members'); + } + public function getPlaceholderText() { return pht('Type members()...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php b/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php index d4f569e78c..ed24e5e88b 100644 --- a/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectNoProjectsDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse Not In Any Projects'); + } + public function getPlaceholderText() { return pht('Type "not in any projects"...'); } diff --git a/src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php b/src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php index 2024fa3b8b..224828ee68 100644 --- a/src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorProjectOrUserDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Users and Projects'); + } + public function getPlaceholderText() { return pht('Type a user or project name...'); } diff --git a/src/applications/search/typeahead/PhabricatorSearchDatasource.php b/src/applications/search/typeahead/PhabricatorSearchDatasource.php index fde4438bbd..65feed5fd2 100644 --- a/src/applications/search/typeahead/PhabricatorSearchDatasource.php +++ b/src/applications/search/typeahead/PhabricatorSearchDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorSearchDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Results'); + } + public function getPlaceholderText() { return pht('Type an object name...'); } diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php index 773c031e43..dcca0782bb 100644 --- a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php +++ b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php @@ -225,7 +225,7 @@ final class PhabricatorTypeaheadModularDatasourceController return $this->newDialog() ->setWidth(AphrontDialogView::WIDTH_FORM) ->setRenderDialogAsDiv(true) - ->setTitle(get_class($source)) // TODO: Provide nice names. + ->setTitle($source->getBrowseTitle()) ->appendChild($browser) ->addCancelButton('/', pht('Close')); } diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php index 63f5737f57..4c51deb3a2 100644 --- a/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php +++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php @@ -88,6 +88,11 @@ abstract class PhabricatorTypeaheadDatasource extends Phobject { } abstract public function getPlaceholderText(); + + public function getBrowseTitle() { + return get_class($this); + } + abstract public function getDatasourceApplicationClass(); abstract public function loadResults(); diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadMonogramDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadMonogramDatasource.php index ebaf3d39d8..4a530d4be3 100644 --- a/src/applications/typeahead/datasource/PhabricatorTypeaheadMonogramDatasource.php +++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadMonogramDatasource.php @@ -10,6 +10,10 @@ final class PhabricatorTypeaheadMonogramDatasource return false; } + public function getBrowseTitle() { + return pht('Browse Objects'); + } + public function getPlaceholderText() { return pht('Type an object name...'); } diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php index 76dd3148d8..61f2c89713 100644 --- a/src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php +++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorTypeaheadNoOwnerDatasource extends PhabricatorTypeaheadDatasource { + public function getBrowseTitle() { + return pht('Browse No Owner'); + } + public function getPlaceholderText() { return pht('Type "none"...'); } diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php index a2aaf4f991..bfd8b090d6 100644 --- a/src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php +++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php @@ -3,6 +3,10 @@ final class PhabricatorTypeaheadOwnerDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Owners'); + } + public function getPlaceholderText() { return pht('Type a user name or "none"...'); } diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php index 96584b6b64..373326ce38 100644 --- a/src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php +++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php @@ -3,8 +3,12 @@ final class PhabricatorTypeaheadUserParameterizedDatasource extends PhabricatorTypeaheadCompositeDatasource { + public function getBrowseTitle() { + return pht('Browse Users'); + } + public function getPlaceholderText() { - return pht('Type a username or selector...'); + return pht('Type a username or function...'); } public function getComponentDatasources() {