mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-20 02:38:39 +01:00
Don't trigger audits for archived packages
Summary: Ref T10939. This is just a bug. I thought this was what was described in T10174 but that's actually talking about something completely different. Also make a `<select />` slightly easier to use. Test Plan: - Created a package with auditing enabled. - Pushed a change. - Saw audit trigger. - Disabled the package, pushed a change. - Before patch: saw audit trigger improperly. - After patch: restarted daemons, then saw audit correctly not trigger. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10939 Differential Revision: https://secure.phabricator.com/D15907
This commit is contained in:
parent
1c73ad6a1b
commit
e5f2ccc57f
2 changed files with 6 additions and 1 deletions
|
@ -82,7 +82,7 @@ final class PhabricatorOwnersPathsController
|
|||
}
|
||||
}
|
||||
|
||||
$repos = mpull($repos, 'getMonogram', 'getPHID');
|
||||
$repos = mpull($repos, 'getDisplayName', 'getPHID');
|
||||
asort($repos);
|
||||
|
||||
$template = new AphrontTypeaheadTemplateView();
|
||||
|
|
|
@ -51,6 +51,11 @@ final class PhabricatorRepositoryCommitOwnersWorker
|
|||
continue;
|
||||
}
|
||||
|
||||
if ($package->isArchived()) {
|
||||
// Don't trigger audits if the package is archived.
|
||||
continue;
|
||||
}
|
||||
|
||||
if ($package->getAuditingEnabled()) {
|
||||
$reasons = $this->checkAuditReasons($commit, $package);
|
||||
if ($reasons) {
|
||||
|
|
Loading…
Add table
Reference in a new issue