From e64dfbcbd85fd816c69864b1f206aeb83dbaaff2 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 31 May 2016 12:04:44 -0700 Subject: [PATCH] Fix top margin on infoview + two-column Summary: When you save settings or don't have reviewers, we show an info box inside an object box. This rule is squashing the margin. Blame seems to indicate I added it for Differential updates, but in re-visiting Differential, I'm unable to trigger any broken CSS with this change. But keep an eye out? Test Plan: Badges, Settings, Differential Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15992 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/phui/phui-two-column-view.css | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 3bd1fd002a..6381ac0a3c 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -156,7 +156,7 @@ return array( 'rsrc/css/phui/phui-status.css' => 'd5263e49', 'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2', 'rsrc/css/phui/phui-timeline-view.css' => '6e342216', - 'rsrc/css/phui/phui-two-column-view.css' => 'b9538af1', + 'rsrc/css/phui/phui-two-column-view.css' => 'ce672be4', 'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7', 'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647', 'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5', @@ -859,7 +859,7 @@ return array( 'phui-tag-view-css' => '6bbd83e2', 'phui-theme-css' => '027ba77e', 'phui-timeline-view-css' => '6e342216', - 'phui-two-column-view-css' => 'b9538af1', + 'phui-two-column-view-css' => 'ce672be4', 'phui-workboard-color-css' => 'ac6fe6a7', 'phui-workboard-view-css' => 'e6d89647', 'phui-workcard-view-css' => '0c62d7c5', diff --git a/webroot/rsrc/css/phui/phui-two-column-view.css b/webroot/rsrc/css/phui/phui-two-column-view.css index 4d71c3d5ba..9aa4c8047c 100644 --- a/webroot/rsrc/css/phui/phui-two-column-view.css +++ b/webroot/rsrc/css/phui/phui-two-column-view.css @@ -203,10 +203,6 @@ padding: 16px; } -.phui-two-column-view .phui-two-column-row .phui-object-box - .phui-info-view { - margin: 0; -} .phui-two-column-view .phui-box-blue-property .phui-header-shell + .phui-info-view {