revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Let JSHint know that the show_details function is an exported global

Browse source 
Summary:
The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning:

```
>>> Lint for webroot/rsrc/js/core/behavior-error-log.js:

   Warning  (W098) JSHintW098
    'show_details' is defined but never used.

               5
               6 var current_details = null;
               7
    >>>        8 function show_details(row) {
               9   var node = JX.$('row-details-' + row);
              10
              11   if (current_details !== null) {
```

Test Plan: `arc lint`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11063
This commit is contained in:
Joshua Spence 2014-12-30 02:51:31 -08:00 committed by epriestley
parent 3f0bc79e0a
commit e6684af73c
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array(
'core.pkg.css' => 'f588bfc3',
'core.pkg.js' => '2d1f7db1',
'darkconsole.pkg.js' => 'df001cab',
'darkconsole.pkg.js' => 'ac37f0cd',
'differential.pkg.css' => '8af45893',
'differential.pkg.js' => '42c10e78',
'diffusion.pkg.css' => '591664fa',
@ -450,7 +450,7 @@ return array(
'rsrc/js/core/behavior-dark-console.js' => '357b6e9b',
'rsrc/js/core/behavior-device.js' => '03d6ed07',
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '92eb531d',
'rsrc/js/core/behavior-error-log.js' => 'a5d7cf86',
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
'rsrc/js/core/behavior-fancy-datepicker.js' => 'c51ae228',
'rsrc/js/core/behavior-file-tree.js' => '88236f00',
'rsrc/js/core/behavior-form.js' => '5c54cbf3',
@ -577,7 +577,7 @@ return array(
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
'javelin-behavior-diffusion-pull-lastmodified' => '2b228192',
'javelin-behavior-doorkeeper-tag' => 'e5822781',
'javelin-behavior-error-log' => 'a5d7cf86',
'javelin-behavior-error-log' => '6882e80a',
'javelin-behavior-fancy-datepicker' => 'c51ae228',
'javelin-behavior-global-drag-and-drop' => '07f199d8',
'javelin-behavior-herald-rule-editor' => '7ebaeed3',
@ -1218,6 +1218,9 @@ return array(
'javelin-dom',
'javelin-fx',
),
'6882e80a' => array(
'javelin-dom',
),
'6932def3' => array(
'javelin-behavior',
'javelin-stratcom',
@ -1482,9 +1485,6 @@ return array(
'javelin-dom',
'phabricator-notification',
),
'a5d7cf86' => array(
'javelin-dom',
),
'a80d0378' => array(
'javelin-behavior',
'javelin-stratcom',

2
webroot/rsrc/js/core/behavior-error-log.js
View file

@ -3,6 +3,8 @@
* @requires javelin-dom
*/
/* exported show_details */
var current_details = null;
function show_details(row) {