From e67302a4c9c1aca4277bfc41ad9275e1309eee65 Mon Sep 17 00:00:00 2001 From: Vasyl Vavrychuk Date: Mon, 25 Nov 2013 20:05:36 -0800 Subject: [PATCH] Display closed documents with crossed text in search result. Summary: By default in search application document status field is "Open and Closed Documents". Often searching with this default status I get confused that open and closed items in search result are not distinguished. Test Plan: Search and see open/closed issues distinguished. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: epriestley CC: epriestley, aran, Korvin Differential Revision: https://secure.phabricator.com/D7626 --- .../search/view/PhabricatorSearchResultView.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/applications/search/view/PhabricatorSearchResultView.php b/src/applications/search/view/PhabricatorSearchResultView.php index f7213f60ae..fe9e4a8c05 100644 --- a/src/applications/search/view/PhabricatorSearchResultView.php +++ b/src/applications/search/view/PhabricatorSearchResultView.php @@ -53,7 +53,10 @@ final class PhabricatorSearchResultView extends AphrontView { ''); } - $object_name = $handle->getFullName(); + $title = $this->emboldenQuery($handle->getFullName()); + if ($handle->getStatus() == PhabricatorObjectHandleStatus::STATUS_CLOSED) { + $title = phutil_tag('del', array(), $title); + } return hsprintf( '
'. @@ -71,7 +74,7 @@ final class PhabricatorSearchResultView extends AphrontView { 'class' => 'result-name', 'href' => $handle->getURI(), ), - $this->emboldenQuery($object_name)), + $title), $type_name, $link); }