revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Rename "Edit Column" to "Column Details"

Browse source 
Summary: Ref T9089. This link leads to a detail page, not an edit page, and is always visible by users with permission to see the column.

Test Plan: Clicked "Column Details" with and without edit permission.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9089

Differential Revision: https://secure.phabricator.com/D14016
This commit is contained in:
epriestley 2015-08-31 10:17:44 -07:00
parent e9614df76e
commit e67c438943
2 changed files with 5 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View file

@ -639,15 +639,13 @@ final class PhabricatorProjectBoardViewController
->setHref($batch_edit_uri) ->setHref($batch_edit_uri)
->setDisabled(!$can_batch_edit); ->setDisabled(!$can_batch_edit);
$edit_uri = $this->getApplicationURI( $detail_uri = $this->getApplicationURI(
'board/'.$this->id.'/column/'.$column->getID().'/'); 'board/'.$this->id.'/column/'.$column->getID().'/');
$column_items[] = id(new PhabricatorActionView()) $column_items[] = id(new PhabricatorActionView())
->setIcon('fa-pencil') ->setIcon('fa-columns')
->setName(pht('Edit Column')) ->setName(pht('Column Details'))
->setHref($edit_uri) ->setHref($detail_uri);
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit);
$can_hide = ($can_edit && !$column->isDefaultColumn()); $can_hide = ($can_edit && !$column->isDefaultColumn());
$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/'; $hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';

12
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
View file

@ -17,7 +17,6 @@ final class PhabricatorProjectColumnDetailController
->withIDs(array($project_id)) ->withIDs(array($project_id))
->needImages(true) ->needImages(true)
->executeOne(); ->executeOne();
if (!$project) { if (!$project) {
return new Aphront404Response(); return new Aphront404Response();
} }
@ -40,7 +39,7 @@ final class PhabricatorProjectColumnDetailController
new PhabricatorProjectColumnTransactionQuery()); new PhabricatorProjectColumnTransactionQuery());
$timeline->setShouldTerminate(true); $timeline->setShouldTerminate(true);
$title = pht('%s', $column->getDisplayName()); $title = $column->getDisplayName();
$header = $this->buildHeaderView($column); $header = $this->buildHeaderView($column);
$actions = $this->buildActionView($column); $actions = $this->buildActionView($column);
@ -113,15 +112,6 @@ final class PhabricatorProjectColumnDetailController
->setObject($column) ->setObject($column)
->setActionList($actions); ->setActionList($actions);
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
$viewer,
$column);
$properties->addProperty(
pht('Editable By'),
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
$limit = $column->getPointLimit(); $limit = $column->getPointLimit();
$properties->addProperty( $properties->addProperty(
pht('Point Limit'), pht('Point Limit'),