From e69f8f717b80b157dd757f861667654db8abef69 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 20 Mar 2017 15:02:52 -0700 Subject: [PATCH] Fix 'Add to Dashboard' issue with builtins Summary: Ref T5307. Actually check the built in query with query, not engine. Test Plan: Try a builtin query, and a custom query when making a dashboard panel. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T5307 Differential Revision: https://secure.phabricator.com/D17521 --- .../PhabricatorDashboardQueryPanelInstallController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php b/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php index 846ada7d05..ecc635966e 100644 --- a/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php +++ b/src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php @@ -29,7 +29,7 @@ final class PhabricatorDashboardQueryPanelInstallController $engine = $engines[$v_engine]; $engine->setViewer($viewer); $good_query = false; - if ($engine->isBuiltinQuery($v_engine)) { + if ($engine->isBuiltinQuery($v_query)) { $good_query = true; } else { $saved_query = id(new PhabricatorSavedQueryQuery())