revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 09:20:58 +01:00
Code Issues Releases Wiki Activity

fixing unloaded object handles for project member changes in feed view

Browse source 
Summary: Fixes T2688

Test Plan: verified proper display in `/feed/` and activity streams

Reviewers: epriestley, nevogd

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2688

Differential Revision: https://secure.phabricator.com/D5279
This commit is contained in:
Anh Nhan Nguyen 2013-03-07 12:57:39 -08:00 committed by epriestley
parent 1797e51428
commit e6c73a8396
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/applications/feed/story/PhabricatorFeedStoryProject.php
View file

@ -6,6 +6,21 @@ final class PhabricatorFeedStoryProject extends PhabricatorFeedStory {
return $this->getValue('projectPHID'); return $this->getValue('projectPHID');
} }
public function getRequiredHandlePHIDs() {
$req_phids = array();
$data = $this->getStoryData();
switch ($data->getValue('type')) {
case PhabricatorProjectTransactionType::TYPE_MEMBERS:
$old = $data->getValue('old');
$new = $data->getValue('new');
$add = array_diff($new, $old);
$rem = array_diff($old, $new);
$req_phids = array_merge($add, $rem);
break;
}
return array_merge($req_phids, parent::getRequiredHandlePHIDs());
}
public function renderView() { public function renderView() {
$data = $this->getStoryData(); $data = $this->getStoryData();