From e7419d85f700c1e18f773e9a58faa4ea45db7d54 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Thu, 10 Apr 2014 14:38:23 -0700 Subject: [PATCH] Set `celerity.minify` true in production environments. Summary: I haven't been able to understand why this isn't set by default in production environments (since it is recommended to do so anyway). Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8743 --- conf/default.conf.php | 2 +- conf/development.conf.php | 1 + .../config/option/PhabricatorDeveloperConfigOptions.php | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/conf/default.conf.php b/conf/default.conf.php index a44169b664..0dba06738f 100644 --- a/conf/default.conf.php +++ b/conf/default.conf.php @@ -980,7 +980,7 @@ return array( // Minify static resources by removing whitespace and comments. You should // enable this in production, but disable it in development. - 'celerity.minify' => false, + 'celerity.minify' => true, // You can respond to various application events by installing listeners, // which will receive callbacks when interesting things occur. Specify a list diff --git a/conf/development.conf.php b/conf/development.conf.php index 704011402c..e4b1311b9f 100644 --- a/conf/development.conf.php +++ b/conf/development.conf.php @@ -4,5 +4,6 @@ return array( 'phabricator.developer-mode' => true, 'darkconsole.enabled' => true, + 'celerity.minify' => false, ) + phabricator_read_config_file('default'); diff --git a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php index b6fd8aa139..95f841b4ea 100644 --- a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php +++ b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php @@ -97,7 +97,7 @@ final class PhabricatorDeveloperConfigOptions "This option enables verbose error reporting (stack traces, ". "error callouts) and forces disk reads of static assets on ". "every reload.")), - $this->newOption('celerity.minify', 'bool', false) + $this->newOption('celerity.minify', 'bool', true) ->setBoolOptions( array( pht('Minify static resources.'),