Add HarbormasterHookController as an entry point for all Harbormaster hooks

Summary: This makes the set of hooks easily extensible, as a first step toward integrating more 3rd party CI in phorge.

Test Plan: Send requests to `/harbormaster/hook/circleci/` and `/harbormaster/hook/buildkite/` and check they run the proper handler.

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: Matthew, speck, tobiaswiese

Maniphest Tasks: T15018

Differential Revision: https://we.phorge.it/D25005

src/__phutil_library_map__.php

@@ -1478,13 +1478,13 @@ phutil_register_library_map(array(
     'HarbormasterBuildableTransactionEditor' => 'applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php',
     'HarbormasterBuildableTransactionQuery' => 'applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php',
     'HarbormasterBuildableViewController' => 'applications/harbormaster/controller/HarbormasterBuildableViewController.php',
-    'HarbormasterBuildkiteBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php',
+    'HarbormasterBuildkiteBuildStepImplementation' => 'applications/harbormaster/integration/buildkite/HarbormasterBuildkiteBuildStepImplementation.php',
     'HarbormasterBuildkiteBuildableInterface' => 'applications/harbormaster/interface/HarbormasterBuildkiteBuildableInterface.php',
-    'HarbormasterBuildkiteHookController' => 'applications/harbormaster/controller/HarbormasterBuildkiteHookController.php',
+    'HarbormasterBuildkiteHookHandler' => 'applications/harbormaster/integration/buildkite/HarbormasterBuildkiteHookHandler.php',
     'HarbormasterBuiltinBuildStepGroup' => 'applications/harbormaster/stepgroup/HarbormasterBuiltinBuildStepGroup.php',
-    'HarbormasterCircleCIBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php',
+    'HarbormasterCircleCIBuildStepImplementation' => 'applications/harbormaster/integration/circleci/HarbormasterCircleCIBuildStepImplementation.php',
     'HarbormasterCircleCIBuildableInterface' => 'applications/harbormaster/interface/HarbormasterCircleCIBuildableInterface.php',
-    'HarbormasterCircleCIHookController' => 'applications/harbormaster/controller/HarbormasterCircleCIHookController.php',
+    'HarbormasterCircleCIHookHandler' => 'applications/harbormaster/integration/circleci/HarbormasterCircleCIHookHandler.php',
     'HarbormasterConduitAPIMethod' => 'applications/harbormaster/conduit/HarbormasterConduitAPIMethod.php',
     'HarbormasterControlBuildStepGroup' => 'applications/harbormaster/stepgroup/HarbormasterControlBuildStepGroup.php',
     'HarbormasterController' => 'applications/harbormaster/controller/HarbormasterController.php',
@@ -1498,6 +1498,8 @@ phutil_register_library_map(array(
     'HarbormasterExternalBuildStepGroup' => 'applications/harbormaster/stepgroup/HarbormasterExternalBuildStepGroup.php',
     'HarbormasterFileArtifact' => 'applications/harbormaster/artifact/HarbormasterFileArtifact.php',
     'HarbormasterHTTPRequestBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php',
+    'HarbormasterHookController' => 'applications/harbormaster/controller/HarbormasterHookController.php',
+    'HarbormasterHookHandler' => 'applications/harbormaster/integration/HarbormasterHookHandler.php',
     'HarbormasterHostArtifact' => 'applications/harbormaster/artifact/HarbormasterHostArtifact.php',
     'HarbormasterLeaseWorkingCopyBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php',
     'HarbormasterLintMessagesController' => 'applications/harbormaster/controller/HarbormasterLintMessagesController.php',
@@ -7727,10 +7729,10 @@ phutil_register_library_map(array(
     'HarbormasterBuildableTransactionQuery' => 'PhabricatorApplicationTransactionQuery',
     'HarbormasterBuildableViewController' => 'HarbormasterController',
     'HarbormasterBuildkiteBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
-    'HarbormasterBuildkiteHookController' => 'HarbormasterController',
+    'HarbormasterBuildkiteHookHandler' => 'HarbormasterHookHandler',
     'HarbormasterBuiltinBuildStepGroup' => 'HarbormasterBuildStepGroup',
     'HarbormasterCircleCIBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
-    'HarbormasterCircleCIHookController' => 'HarbormasterController',
+    'HarbormasterCircleCIHookHandler' => 'HarbormasterHookHandler',
     'HarbormasterConduitAPIMethod' => 'ConduitAPIMethod',
     'HarbormasterControlBuildStepGroup' => 'HarbormasterBuildStepGroup',
     'HarbormasterController' => 'PhabricatorController',
@@ -7744,6 +7746,8 @@ phutil_register_library_map(array(
     'HarbormasterExternalBuildStepGroup' => 'HarbormasterBuildStepGroup',
     'HarbormasterFileArtifact' => 'HarbormasterArtifact',
     'HarbormasterHTTPRequestBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
+    'HarbormasterHookController' => 'HarbormasterController',
+    'HarbormasterHookHandler' => 'Phobject',
     'HarbormasterHostArtifact' => 'HarbormasterDrydockLeaseArtifact',
     'HarbormasterLeaseWorkingCopyBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
     'HarbormasterLintMessagesController' => 'HarbormasterController',

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

@@ -94,10 +94,7 @@ final class PhabricatorHarbormasterApplication extends PhabricatorApplication {
         'lint/' => array(
           '(?P<id>\d+)/' => 'HarbormasterLintMessagesController',
         ),
-        'hook/' => array(
+        'hook/(?P<handler>[^/]+)/' => 'HarbormasterHookController',
-          'circleci/' => 'HarbormasterCircleCIHookController',
-          'buildkite/' => 'HarbormasterBuildkiteHookController',
-        ),
         'log/' => array(
           'view/(?P<id>\d+)/(?:\$(?P<lines>\d+(?:-\d+)?))?'
             => 'HarbormasterBuildLogViewController',

src/applications/harbormaster/controller/HarbormasterHookController.php

@@ -0,0 +1,21 @@
+<?php
+
+final class HarbormasterHookController
+  extends HarbormasterController {
+
+  public function shouldRequireLogin() {
+    return false;
+  }
+
+  public function handleRequest(AphrontRequest $request) {
+    $name = $request->getURIData('handler');
+    $handler = HarbormasterHookHandler::getHandler($name);
+
+    if (!$handler) {
+      throw new Exception(pht('No handler found for %s', $name));
+    }
+
+    return $handler->handleRequest($request);
+  }
+
+}

src/applications/harbormaster/integration/HarbormasterHookHandler.php

@@ -0,0 +1,27 @@
+<?php
+
+abstract class HarbormasterHookHandler
+  extends Phobject {
+
+  public static function getHandlers() {
+    return id(new PhutilClassMapQuery())
+      ->setAncestorClass(__CLASS__)
+      ->setUniqueMethod('getName')
+      ->execute();
+  }
+
+  public static function getHandler($handler) {
+    $base = idx(self::getHandlers(), $handler);
+
+    if ($base) {
+      return (clone $base);
+    }
+
+    return null;
+  }
+
+  abstract public function getName();
+
+  abstract public function handleRequest(AphrontRequest $request);
+
+}

src/applications/harbormaster/integration/buildkite/HarbormasterBuildkiteHookHandler.php

@@ -1,10 +1,10 @@
 <?php
 
-final class HarbormasterBuildkiteHookController
+final class HarbormasterBuildkiteHookHandler
-  extends HarbormasterController {
+  extends HarbormasterHookHandler {
 
-  public function shouldRequireLogin() {
+  public function getName() {
-    return false;
+    return 'buildkite';
   }
 
   /**

src/applications/harbormaster/integration/circleci/HarbormasterCircleCIHookHandler.php

@@ -1,10 +1,10 @@
 <?php
 
-final class HarbormasterCircleCIHookController
+final class HarbormasterCircleCIHookHandler
-  extends HarbormasterController {
+  extends HarbormasterHookHandler {
 
-  public function shouldRequireLogin() {
+  public function getName() {
-    return false;
+    return 'circleci';
   }
 
   /**