mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-22 05:20:56 +01:00
Prevent an error when the Drydock lease artifact does not exist
Summary: If a host artifact exists in a Harbormaster build, where the Drydock lease no longer exists, then an error will be raised because of the attempt to access an undefined index. This changes the code to use `idx()` so that it correctly returns null instead. Test Plan: Tested in production. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: joshuaspence, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D13074
This commit is contained in:
parent
8ea13f3ce9
commit
e7e585820b
1 changed files with 1 additions and 1 deletions
|
@ -77,7 +77,7 @@ final class HarbormasterBuildArtifact extends HarbormasterDAO
|
|||
->setViewer($viewer)
|
||||
->withIDs(array($data['drydock-lease']))
|
||||
->execute();
|
||||
$lease = $leases[$data['drydock-lease']];
|
||||
$lease = idx($leases, $data['drydock-lease']);
|
||||
|
||||
return id(new PHUIObjectItemView())
|
||||
->setObjectName(pht('Drydock Lease'))
|
||||
|
|
Loading…
Reference in a new issue