From e7e8ef7e390a8a777087974c6e1a281c107ca565 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 20 Jan 2021 15:02:06 -0800 Subject: [PATCH] Correct a straggling CLI format string after ref selector changes Summary: Ref T13589. This is missing a "%s" conversion. Test Plan: Will view a commit with a diff. Maniphest Tasks: T13589 Differential Revision: https://secure.phabricator.com/D21512 --- .../diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php b/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php index 5983b2723e..9c894437ef 100644 --- a/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php +++ b/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php @@ -23,7 +23,7 @@ final class DiffusionGitRawDiffQuery extends DiffusionRawDiffQuery { // Check if this is the root commit by seeing if it has parents, since // `git diff X^ X` does not work if "X" is the initial commit. list($parents) = $repository->execxLocalCommand( - 'log -n 1 %s --', + 'log -n 1 %s %s --', '--format=%P', gitsprintf('%s', $commit));